Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 86942
Status: open
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: TIMB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Is Perl::Critic being maintained?
Download (untitled) / with headers
text/plain 178b
I see ~170 open issues, quite a few with patches, but no release in the past 12 months. I wonder if more commit bits and/or a move to a more 'social' repo like github might help.
Subject: Re: [rt.cpan.org #86942] Is Perl::Critic being maintained?
Date: Tue, 16 Jul 2013 00:14:34 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Show quoted text
> > > I see ~170 open issues, quite a few with patches, but no release in the > past 12 months. > I wonder if more commit bits and/or a move to a more 'social' repo like > github might help. >
Hi Tim- I haven't been able to keep up. All my time is focused on Pinto and Stratopan right now. I can't make any promises about when the next Perl-Critic release will be. I would love to move to GitHub. I even wrote some code to migrate all the issues from RT. And at one point, frewSchmidt wrote a script to migrate the repo (we did some weird stuff in svn). But I'm not sure it really worked and I haven't had time to debug it. I hear there are better migration tools now anyway. You are more than welcome to take a crack at it. I can send you a dump of the whole svn repo to work from. I don't even care about the ancient history that much. As long as the recent stuff (like last 3-4 years) is there, then I'm probably happy. There is a Perl-Critic organization on GitHub. I'd be happy to make you an owner. -Jeff
Download (untitled) / with headers
text/plain 304b
Show quoted text
> There is a Perl-Critic organization on GitHub. I'd be happy to make you an owner.
I don't know how much time I'll have to contribute directly, but I might be able to do some cat herding to move things forward. So, yes, please do. Also, are you happy for me to be a co-maint (to manage the RT queue)?
Download (untitled) / with headers
text/plain 383b
Could you put that dump of the svn repo online somewhere? I could take a crack at converting the repos there as well if you want. We have converted a lot of repos at work (including things like splitting one svn repo into many git repos). How important are the "difficult" things, like branches, and tags? I assume tags are more important, but I don't know the state of the branches
Subject: Re: [rt.cpan.org #86942] Is Perl::Critic being maintained?
Date: Tue, 16 Jul 2013 04:55:34 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Here's the svn dump: http://perlcritic.tigris.org/files/documents/3323/49262/perlcritic.dump.tar.gz I would definitely want the tags from the last 3 or 4 years. Branches during that time would be nice, but not mandatory. Moving to GitHub is more important. Anything older than 4 years can be discarded/ignored if it causes you any grief. I really appreciate this. Don't bother yourself with Test-Perl-Critic and the other distros in there. I would like to move them too eventually, but they are far less important. On Tue, Jul 16, 2013 at 3:49 AM, Andreas Marienborg via RT < bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> Queue: Perl-Critic > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86942 > > > Could you put that dump of the svn repo online somewhere? I could take a > crack at converting the repos there as well if you want. We have converted > a lot of repos at work (including things like splitting one svn repo into > many git repos). > > How important are the "difficult" things, like branches, and tags? I > assume tags are more important, but I don't know the state of the branches >
Subject: Re: [rt.cpan.org #86942] Is Perl::Critic being maintained?
Date: Tue, 16 Jul 2013 05:02:50 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 571b
Show quoted text
> > I don't know how much time I'll have to contribute directly, but I might > be able to do some cat herding to move things forward. So, yes, please do. >
Done. Show quoted text
> > Also, are you happy for me to be a co-maint (to manage the RT queue)? >
Will do, if I can remember how :) Thanks so much! I saw your call to action on Twitter. By the way: I recently discovered this: https://codeclimate.com. I always wanted to do something like that. Especially since Perl has the *best* static analyzer among all the dynamic languages. There is real money on the table there.
Subject: Re: [rt.cpan.org #86942] Is Perl::Critic being maintained?
Date: Tue, 16 Jul 2013 05:08:25 -0700
To: bug-perl-critic <bug-Perl-Critic [...] rt.cpan.org>
From: "Thalhammer, Jeffrey" <jeff [...] imaginative-software.com>
Download (untitled) / with headers
text/plain 338b
Show quoted text
> I always wanted to do something like that. Especially since Perl has the
*best* static analyzer among all the dynamic languages. Oooo, I bet you could put together an NYTProf service -- Hook into git, run analysis after commits, track performance over time, pretty dashboards. These dev-tools-as-a-service ideas are golden. Profit!
Download (untitled) / with headers
text/plain 1.4k
For what it's worth, here is the script I ended up with: https://github.com/frioux/Git-Conversions/blob/master/perl-critic-convert If I recall correctly the reason I stopped was mostly due to ratelimiting issues. On Tue Jul 16 07:55:50 2013, jeff@imaginative-software.com wrote: Show quoted text
> Here's the svn dump: > http://perlcritic.tigris.org/files/documents/3323/49262/perlcritic.dump.tar.gz > > I would definitely want the tags from the last 3 or 4 years. Branches > during that time would be nice, but not mandatory. Moving to GitHub > is > more important. Anything older than 4 years can be discarded/ignored > if it > causes you any grief. > > I really appreciate this. Don't bother yourself with Test-Perl-Critic > and > the other distros in there. I would like to move them too eventually, > but > they are far less important. > > > On Tue, Jul 16, 2013 at 3:49 AM, Andreas Marienborg via RT < > bug-Perl-Critic@rt.cpan.org> wrote: >
> > Queue: Perl-Critic > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86942 > > > > > Could you put that dump of the svn repo online somewhere? I could
> take a
> > crack at converting the repos there as well if you want. We have
> converted
> > a lot of repos at work (including things like splitting one svn repo
> into
> > many git repos). > > > > How important are the "difficult" things, like branches, and tags? I > > assume tags are more important, but I don't know the state of the
> branches
> >
Download (untitled) / with headers
text/plain 1.9k
On Tue Jul 16 06:49:23 2013, ANDREMAR wrote: Show quoted text
> Could you put that dump of the svn repo online somewhere? I could take > a crack at converting the repos there as well if you want. We have > converted a lot of repos at work (including things like splitting > one svn repo into many git repos). > > How important are the "difficult" things, like branches, and tags? I > assume tags are more important, but I don't know the state of the > branches
Branches I know myself to have committed: * rt64929 - This was for the ticket of the same number, which was about having ProhibitUnusedVariables find more unused variables. The work bogged down with concerns about false positives. The code has been released as a separate distribution, Perl-Critic-Policy-Variables-ProhibitUnusedVarsStricter, the branch deleted, and the ticket closed. * rt38289 - This was for the ticket of the same number, which called for a policy flagging capture variables in subroutine arguments. I have no idea of the state of this code, though I know it was never merged into the core. If this would be better as a separate policy please let me know, though I can't commit to getting it quickly. * violation_named_args - Work to convert violation creation from positional argumnents to named arguments. The aim was to be able to override the line and column numbers calculated from the PPI object (e.g. to provide a better idea where the error was in a large block of POD). This was abandoned because of concerns over where to put the '## no critic' if the error was to be suppressed. It can probably be deleted. Unfortunately there are a lot of other things going on in my life right now, not all of them things I would wish for. What time I have had for Perl has been largely consumed by Astro::SpaceTrack (U. S. Strat Com changed the API, and the old one retired today). I know excuses are not what Perl::Critic needs right now. I will do what I can. Tom
Download (untitled) / with headers
text/plain 117b
On Wed Jul 17 06:09:09 2013, WYANT wrote: Show quoted text
> [...useful history...] > > I will do what I can.
Understood. Thanks Tom.
Download (untitled) / with headers
text/plain 559b
Ok, I've let my exporter run overnight and now I have an ok export. I cannot push it to github because at some point a bunch of gigantic java files got added directly to the repo. I'm going to filter out the buildserver directory (if anyone wants it they can get it from subversion :) as well as update some of the tags that have been created since I started my conversion a couple years ago. Expect an update later today. Also, one thing I'll go ahead and do is add a bunch of comments to the conversion so you guys can look it over and check what I did.
RT-Send-CC: andreas.marienborg [...] gmail.com
Download (untitled) / with headers
text/plain 457b
On Wed Jul 17 14:17:36 2013, frew wrote: Show quoted text
> Ok, I've let my exporter run overnight and now I have an ok export. [...] Expect an update later today.
Thanks great! Show quoted text
> (Also, one thing I'll go ahead and do is add a bunch of comments to the conversion so you guys can look it over and check what I did.)
Thanks. Also, please post further updates to the migration ticket https://rt.cpan.org/Ticket/Display.html?id=86973 rather than this one. Thanks again frew.
Download (untitled) / with headers
text/plain 313b
Le 2013-07-16 12:47:03, TIMB a écrit : Show quoted text
> Also, are you happy for me to be a co-maint (to manage the RT queue)?
You don't have to be co-maint to manage the RT queue. Just add yourself as a requester to each ticket and you get full rights to modify the ticket. -- Olivier Mengué - http://perlresume.org/DOLMEN
Download (untitled) / with headers
text/plain 301b
Le 2013-07-15 13:07:12, TIMB a écrit : Show quoted text
> I see ~170 open issues, quite a few with patches, but no release in
I'll resubmit my own patches (RT#75300, RT#75329) as pull requests as soon as the code is on Github. Or directly if I get a commit bit... -- Olivier Mengué - http://perlresume.org/DOLMEN


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.