Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id:
86208
Status:
new
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
scfrd1 [...] gmail.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: Patch for _is_backup in Perl::Critic::Utils
Date: Mon, 17 Jun 2013 12:55:51 -0700
To: bug-Perl-Critic@rt.cpan.org
From: Steve Cayford <scfrd1@gmail.com>
Hi, The all_perl_files routine returns files named like #filename# when searching through directories since the regex expects to be looking at only the filename rather than the whole path. Here's a simple patch for that if you're interested... --- Perl/Critic/Utils.pm~ 2013-06-17 12:35:49.378382179 -0700 +++ Perl/Critic/Utils.pm 2013-06-17 12:42:08.548773772 -0700 @@ -1117,6 +1117,7 @@ sub _is_backup { my ($file) = @_; + ( undef, undef, $file ) = File::Spec->splitpath( $file ); return 1 if $file =~ m{ [.] swp \z}xms; return 1 if $file =~ m{ [.] bak \z}xms; return 1 if $file =~ m{ ~ \z}xms;


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.