Skip Menu |
 

This queue is for tickets about the GD CPAN distribution.

Report information
The Basics
Id: 85789
Status: resolved
Priority: 0/
Queue: GD

People
Owner: Nobody in particular
Requestors: abraxxa [...] cpan.org
cjwatson [...] ubuntu.com
SREZIC [...] cpan.org
tsibley [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: GD-2.46 fails most tests with libgd 2.1.0-rc1
Date: Sat, 1 Jun 2013 23:32:43 +0100
To: bug-GD [...] rt.cpan.org
From: Colin Watson <cjwatson [...] ubuntu.com>
Download (untitled) / with headers
text/plain 2.1k
libgd 2.1.0-rc1 (http://libgd.bitbucket.org/) causes GD-2.46 to fail tests on Debian unstable and Ubuntu saucy; perl 5.14.2 in both cases. https://launchpadlibrarian.net/140261612/buildlog_ubuntu-saucy-i386.libgd-gd2-perl_1%3A2.46-3build3_FAILEDTOBUILD.txt.gz /usr/bin/make -C . CFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall" CXXFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall" CPPFLAGS="-D_FORTIFY_SOURCE=2" LDFLAGS="-Wl,-Bsymbolic-functions -Wl,-z,relro" test TEST_VERBOSE=1 make[1]: Entering directory `/build/buildd/libgd-gd2-perl-2.46' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(1, 'blib/lib', 'blib/arch')" t/*.t Testing using png support. t/GD.t ........ 1..12 ok 1 not ok 2 not ok 3 not ok 4 not ok 5 not ok 6 not ok 7 ok 8 # Skip, FreeType changes too frequently to be testable not ok 9 ok 10 # Skip, JPEG test buggy ok 11 ok 12 Failed 7/12 subtests (less 2 skipped subtests: 3 okay) t/Polyline.t .. 1..1 # Running under perl version 5.014002 for linux # Current time local: Sun May 19 23:19:10 2013 # Current time GMT: Sun May 19 23:19:10 2013 # Using Test.pm version 1.25_02 ok 1 ok Test Summary Report ------------------- t/GD.t (Wstat: 0 Tests: 12 Failed: 7) Failed tests: 2-7, 9 Files=2, Tests=13, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.12 cusr 0.00 csys = 0.16 CPU) Result: FAIL Failed 1/2 test programs. 7/13 subtests failed. (Note that Debian carries a patch to disable test 10, hence the discrepancy against the upstream code here.) GD-2.49 contains no changes which would affect this. I ran t/GD.t with --write and the resulting image files for the failing tests are visually indistinguishable from previous ones, so I think this is just another case where the test suite needs to be updated. I've attached a tarball of the *_new files created this way for the affected tests, which could be renamed into place if you so choose. Thanks, -- Colin Watson [cjwatson@ubuntu.com]
Download png-for-libgd-2.1.0.tar.gz
application/octet-stream 13.1k

Message body not shown because it is not plain text.

Subject: [rt.cpan.org #85789] explanation
Date: Tue, 11 Jun 2013 15:57:36 +0200
To: bug-GD [...] rt.cpan.org
From: Remi Collet <remi [...] fedoraproject.org>
Download (untitled) / with headers
text/plain 1.2k
Here is my analysis: $ pngcheck -vtc test.out.4.png ttest.out.4.gd21.png File: test.out.4.png (269 bytes) chunk IHDR at offset 0x0000c, length 13 100 x 50 image, 2-bit palette, non-interlaced chunk PLTE at offset 0x00025, length 12: 4 palette entries chunk IDAT at offset 0x0003d, length 188 zlib: deflated, 32K window, default compression chunk IEND at offset 0x00105, length 0 No errors detected in test.out.4.png (4 chunks, 78.5% compression). File: test.out.4.gd21.png (290 bytes) chunk IHDR at offset 0x0000c, length 13 100 x 50 image, 2-bit palette, non-interlaced chunk PLTE at offset 0x00025, length 12: 4 palette entries chunk pHYs at offset 0x0003d, length 9: 3780x3780 pixels/meter (96 dpi) chunk IDAT at offset 0x00052, length 188 zlib: deflated, 2K window, default compression chunk IEND at offset 0x0011a, length 0 No errors detected in test.out.4.gd21.png (5 chunks, 76.8% compression). New PHYS chunk is expected: From libgd-2.1.0/src/gd_png.c: #ifdef PNG_pHYs_SUPPORTED /* 2.1.0: specify the resolution */ png_set_pHYs(png_ptr, info_ptr, DPI2DPM(im->res_x), DPI2DPM(im->res_y), PNG_RESOLUTION_METER); #endif Deflate window size change from 32k to 2k also expected (commented out): /* png_set_compression_window_bits(png_ptr, 15); */ Regards, Remi
Download (untitled) / with headers
text/plain 599b
On Sat Jun 01 18:33:01 2013, cjwatson@ubuntu.com wrote: Show quoted text
> Testing using png support. > t/GD.t ........ > 1..12 > ok 1 > not ok 2 > not ok 3 > not ok 4 > not ok 5 > not ok 6 > not ok 7 > ok 8 # Skip, FreeType changes too frequently to be testable > not ok 9 > ok 10 # Skip, JPEG test buggy > ok 11 > ok 12 > Failed 7/12 subtests > (less 2 skipped subtests: 3 okay)
Did you set GDIMAGETYPE globally, or just for this test? default is unset, which would test gd2. If your GDIMAGETYPE is global we would need to losen all our comparison tests, as they are way too fragile. -- Reini Urban
Fixed since 2.58


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.