Skip Menu |
 

This queue is for tickets about the XML-Tidy CPAN distribution.

Report information
The Basics
Id: 85592
Status: resolved
Priority: 0/
Queue: XML-Tidy

People
Owner: Pip [...] CPAN.Org
Requestors: MICHIELB [...] cpan.org
Cc: Pip [...] CPAN.Org
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.12.B55J2qn
Fixed in: 1.16



CC: Pip [...] CPAN.Org
Subject: POD tests failing
Download (untitled) / with headers
text/plain 1.6k
commit 3c0833216751607bf876e2b266fecce465febed4 Author: Michiel Beijen <michiel.beijen@otrs.com> Date: Fri May 24 05:31:25 2013 -0400 Fixed POD encoding issue. The encoding was not specified and this caused *some* installations to fail, see for instance these test reports: http://www.cpantesters.org/cpan/report/8c5ef52c-6cb0-1014-97a6-d6e792c9f027 http://www.cpantesters.org/cpan/report/cef27b54-9bf3-11e2-8e13-f0feaa8f1a3b Also, typically it is not recommended to run the POD or POD Coverage tests if the module for testing this is not installed - I changed the test so they are really only run when the module is present. diff --git a/Tidy.pm b/Tidy.pm index 8f2fc8d..7b7f6e9 100644 --- a/Tidy.pm +++ b/Tidy.pm @@ -771,6 +771,8 @@ sub AUTOLOAD { # methods (created as necessary) sub DESTROY { } # do nothing but define in case && to calm test warnings 127; +=encoding utf8 + =head1 NAME XML::Tidy - tidy indenting of XML documents diff --git a/t/00pod.t b/t/00pod.t index 1f204a7..437887a 100644 --- a/t/00pod.t +++ b/t/00pod.t @@ -1 +1,4 @@ -use Test::Pod; all_pod_files_ok(); \ No newline at end of file +use Test::More; +eval "use Test::Pod 1.00"; +plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; +all_pod_files_ok(); diff --git a/t/00podc.t b/t/00podc.t index fcdb4f4..a8b2c6c 100644 --- a/t/00podc.t +++ b/t/00podc.t @@ -1 +1,6 @@ -use Test::Pod::Coverage 'tests' => '1'; pod_coverage_ok('XML::Tidy', 'POD Covered'); \ No newline at end of file +use Test::More; +eval "use Test::Pod::Coverage"; +plan skip_all => "Test::Pod::Coverage required for testing pod coverage" if $@; + +plan tests => 1; +pod_coverage_ok('XML::Tidy', 'POD Covered');
Subject: xml-tidy-pod.patch
Download xml-tidy-pod.patch
text/x-diff 1.6k
commit 3c0833216751607bf876e2b266fecce465febed4 Author: Michiel Beijen <michiel.beijen@otrs.com> Date: Fri May 24 05:31:25 2013 -0400 Fixed POD encoding issue. The encoding was not specified and this caused *some* installations to fail, see for instance these test reports: http://www.cpantesters.org/cpan/report/8c5ef52c-6cb0-1014-97a6-d6e792c9f027 http://www.cpantesters.org/cpan/report/cef27b54-9bf3-11e2-8e13-f0feaa8f1a3b Also, typically it is not recommended to run the POD or POD Coverage tests if the module for testing this is not installed - I changed the test so they are really only run when the module is present. diff --git a/Tidy.pm b/Tidy.pm index 8f2fc8d..7b7f6e9 100644 --- a/Tidy.pm +++ b/Tidy.pm @@ -771,6 +771,8 @@ sub AUTOLOAD { # methods (created as necessary) sub DESTROY { } # do nothing but define in case && to calm test warnings 127; +=encoding utf8 + =head1 NAME XML::Tidy - tidy indenting of XML documents diff --git a/t/00pod.t b/t/00pod.t index 1f204a7..437887a 100644 --- a/t/00pod.t +++ b/t/00pod.t @@ -1 +1,4 @@ -use Test::Pod; all_pod_files_ok(); \ No newline at end of file +use Test::More; +eval "use Test::Pod 1.00"; +plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; +all_pod_files_ok(); diff --git a/t/00podc.t b/t/00podc.t index fcdb4f4..a8b2c6c 100644 --- a/t/00podc.t +++ b/t/00podc.t @@ -1 +1,6 @@ -use Test::Pod::Coverage 'tests' => '1'; pod_coverage_ok('XML::Tidy', 'POD Covered'); \ No newline at end of file +use Test::More; +eval "use Test::Pod::Coverage"; +plan skip_all => "Test::Pod::Coverage required for testing pod coverage" if $@; + +plan tests => 1; +pod_coverage_ok('XML::Tidy', 'POD Covered');
Shouldn't this be =encoding ISO8859-1 ?
From: ppisar [...] redhat.com
Download (untitled) / with headers
text/plain 281b
Dne Ne 16.čen.2013 12:54:12, GREGOA napsal(a): Show quoted text
> Shouldn't this be > > =encoding ISO8859-1 > > ?
Yes. The file uses that character set. However current POD formatters do not work correctly with non-UTF-8 PODs, so converting the whole file to UTF-8 would be beneficial. -- Petr


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.