Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 85107
Status: open
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: fails no_pod_errors , doesn't tell why.

I've hit a weird snag where Test::Kwalitee is failing for a reason it wont divulge, none of the test fails report *which* files cause the fails, or *where* in the files the fails are triggered.
 

More over, in this specific case, it suggests to use Test::Pod to find out whats wrong .... but I'm using that, and its fine.

PERL5OPT='-MCarp::Always' prove -lvr xt/release/kwalitee.t  xt/release/pod-syntax.t
xt/release/kwalitee.t ....
1..13
ok 1 - extractable
ok 2 - has_readme
ok 3 - has_manifest
ok 4 - has_meta_yml
ok 5 - has_buildtool
ok 6 - has_changelog
ok 7 - no_symlinks
ok 8 - has_tests
ok 9 - proper_libs
ok 10 - use_strict
ok 11 - has_test_pod
ok 12 - has_test_pod_coverage
not ok 13 - no_pod_errors

#   Failed test 'no_pod_errors'
#   at /home/kent/perl5/perlbrew/perls/v5.17.10-54_env_warn_stringify/lib/site_perl/5.17.11/Test/Kwalitee.pm line 104.
# Remove the POD errors. You can check for POD errors automatically by including Test::Pod to your test suite.The documentation for this distribution contains syntactic errors in its POD. Note that this metric tests all .pl, .pm and .pod files, even if they are in t/. See 'pod_message' in the dist error view for more info.
# Looks like you failed 1 test of 13.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/13 subtests
xt/release/pod-syntax.t ..
1..5
ok 1 - POD test for lib/ELF/Extract/Sections.pm
ok 2 - POD test for lib/ELF/Extract/Sections/Section.pm
ok 3 - POD test for lib/ELF/Extract/Sections/Scanner/Objdump.pm
ok 4 - POD test for lib/ELF/Extract/Sections/Meta/Scanner.pm
ok 5 - POD test for lib/ELF/Extract/Sections/Meta/Types.pm
ok

Test Summary Report
-------------------
xt/release/kwalitee.t  (Wstat: 256 Tests: 13 Failed: 1)
  Failed test:  13
  Non-zero exit status: 1
Files=2, Tests=18,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.67 cusr  0.07 csys =  0.78 CPU)
Result: FAIL
 

podchecker -warnings $( find -type f  )
./LICENSE does not contain any pod commands.
./Changes does not contain any pod commands.
./lib/ELF/Extract/Sections.pm pod syntax OK.
./lib/ELF/Extract/Sections/Scanner/Objdump.pm pod syntax OK.
./lib/ELF/Extract/Sections/Section.pm pod syntax OK.
./lib/ELF/Extract/Sections/Meta/Scanner.pm pod syntax OK.
./lib/ELF/Extract/Sections/Meta/Types.pm pod syntax OK.
./xt/release/pod-coverage.t does not contain any pod commands.
./xt/release/cpan-changes.t does not contain any pod commands.
./xt/release/pod-syntax.t does not contain any pod commands.
./xt/release/distmeta.t does not contain any pod commands.
./xt/release/minimum-version.t does not contain any pod commands.
./xt/release/kwalitee.t does not contain any pod commands.
./xt/release/eol.t does not contain any pod commands.
./xt/author/critic.t does not contain any pod commands.
./examples/example1.pl pod syntax OK.
./examples/example2.pl pod syntax OK.
./examples/example3.pl does not contain any pod commands.
./Debian_CPANTS.txt does not contain any pod commands.
./Build.PL does not contain any pod commands.
./t/test_files/libreadline.so.6.0.debug.yaml does not contain any pod commands.
./t/test_files/libz.so does not contain any pod commands.
./t/test_files/libc.so.6.yaml does not contain any pod commands.
./t/test_files/libreadline.so.6.0.debug does not contain any pod commands.
./t/test_files/gen_expected.pl does not contain any pod commands.
./t/test_files/libz.so.1.2.3.debug does not contain any pod commands.
./t/test_files/libz.so.1.2.3.debug.yaml does not contain any pod commands.
./t/test_files/libz.so.yaml does not contain any pod commands.
./t/test_files/libc.so.6 does not contain any pod commands.
./t/01-elf-libs.t does not contain any pod commands.
./t/00-compile.t does not contain any pod commands.
./t/000-report-versions-tiny.t does not contain any pod commands.
./LICENSE.tests does not contain any pod commands.
./README does not contain any pod commands.
./META.yml does not contain any pod commands.
./perlcritic.rc does not contain any pod commands.
./LICENCES/ZLIB does not contain any pod commands.
./LICENCES/GPL-3 does not contain any pod commands.
./LICENCES/LGPL-2.1 does not contain any pod commands.
./dist.ini does not contain any pod commands.
./META.json does not contain any pod commands.
./weaver.ini does not contain any pod commands.
./MANIFEST does not contain any pod commands.

Ok, threw MCA at the built dist:

          'error' => {
                       'cpants' => '',
                       'has_version_in_each_file' => [
                                                       'lib/ELF/Extract/Sections/Section.pm',
                                                       'lib/ELF/Extract/Sections/Meta/Scanner.pm',
                                                       'lib/ELF/Extract/Sections/Scanner/Objdump.pm',
                                                       'lib/ELF/Extract/Sections/Meta/Types.pm',
                                                       'lib/ELF/Extract/Sections.pm'
                                                     ],
                       'no_large_files' => 't/test_files/libc.so.6:1718358',
                       'no_pod_errors' => " tmp 3qPAP4Zjc2 ELF Extract Sections 0 03000101 examples example2 pl   POD
ERRORS
Hey  The above document had some coding errors  which are explained below
Around line 33
  Non ASCII character seen before  encoding in  H E1\x{249}L  Assuming UTF 8
",
                       'valid_signature' => -1
                     },
 
So it seems to have found an error that nothing else is reporting.  Indeed, that file does have arbitrary binary data in its POD ( its ok for this context ), and its not liking that due to absense of =encoding

It would just be better if Test::Kwalitee could havve told me this when it encountered the error, so that not so much digging was required.

Subject: fails no_pod_errors , doesn't tell why. (Needs better API)
Download (untitled) / with headers
text/plain 291b
Show quoted text
> It would just be better if Test::Kwalitee could havve told me this > when it > encountered the error, so that not so much digging was required.
I moved this ticket to the MCA queue, as it doesn't seem very clear from the documentation how one should extract error data from the analyser.
RT-Send-CC: KENTNL [...] cpan.org
Download (untitled) / with headers
text/plain 400b
On 2013-05-07 01:52:51, KENTNL wrote: Show quoted text
> It would just be better if Test::Kwalitee could havve told me this > when it > encountered the error, so that not so much digging was required.
Test::Kwalitee 1.06 now does this. However, I suspect I am bypassing the proper MCA interface, so I'm leaving this ticket open in the hope that I can find out the proper way to get the diagnostic data out of MCA.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.