Skip Menu |
 

This queue is for tickets about the PathTools CPAN distribution.

Report information
The Basics
Id: 84915
Status: open
Priority: 0/
Queue: PathTools

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
lxp [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.40
Fixed in: (no value)



Subject: File::Spec::Unix::catdir doesn't check for defined-ness
Download (untitled) / with headers
text/plain 460b
# expected: BOOM # actual: /file.txt File::Spec::Unix->catfile(undef, 'file.txt') No one in their right mind would explicitly pass undef to this function, especially since the behaviour in that situation isn't described in the File::Spec docs. Accidents do happen though (see [rt.cpan.org #84914]), and it would be handy if File::Spec made some noise in this situation so that the cause for failure is more obvious, not occurring at an unnecessary distance.
Download (untitled) / with headers
text/plain 242b
I like it when functions like this throw an exception in case of bogus input. If we were to switch to doing that, would we need a "deprecation period" before making the change? Or does anyone want to argue that we shouldn't make the change?
Download (untitled) / with headers
text/plain 602b
On Tue Apr 30 05:22:28 2013, KWILLIAMS wrote: Show quoted text
> I like it when functions like this throw an exception in case of > bogus input. If we were to switch to doing that, would we need a > "deprecation period" before making the change? Or does anyone want > to argue that we shouldn't make the change?
I'd say more than six months of silence is tacit approval from all relevant parties to make the change. ;) I'd also argue that a deprecation period isn't strictly necessary in this case, because it seems highly likely to me that anywhere that this is occurring in the wild, it's silently failing anyway.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.