Skip Menu |
 

This queue is for tickets about the Template-Toolkit CPAN distribution.

Report information
The Basics
Id: 84778
Status: open
Priority: 0/
Queue: Template-Toolkit

People
Owner: Nobody in particular
Requestors: wyant [...] cpan.org
Cc: alexm [...] cpan.org
dam [...] cpan.org
dom [...] cpan.org
gregoa [...] cpan.org
JHANNAH [...] cpan.org
rsrchboy [...] cpan.org
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: t/vmethods/text.t fails under Perl 5.17.11.
Download (untitled) / with headers
text/plain 667b
Hiding in the bowels of perl51711delta.pod is the statement that the split() built-in has been modified so that if the first argument is an expression evaluating to ' ', it now behaves like a literal ' '. Since test 35 of t/vmethods/text.t relies on the old behavior, it fails. I am not sure what severity to give this. The test failure does not indicate a failure of Template-Toolkit code, and the behavior may not make it into a production version of Perl anyway. But it does require investigation and a force install. Since the subject test actually tests the behavior of split() rather than Template-Toolkit, the attached patch simply removes the failing test.
Subject: Template-t-vmethods-text.patch
--- t/vmethods/text.old 2012-02-07 04:10:53.000000000 -0500 +++ t/vmethods/text.t 2013-04-21 13:38:21.000000000 -0400 @@ -158,12 +158,6 @@ The_dog_sat_on_the_log -- test -- --- name text.split.join d -- -[% spaced.split(' ').join('_') %] --- expect -- -__The_dog_sat_on_the_log - --- test -- -- name text.list -- [% string.list.join %] -- expect --
Subject: Re: [rt.cpan.org #84778] t/vmethods/text.t fails under Perl 5.17.11.
Date: Mon, 22 Apr 2013 18:06:25 +0100
To: bug-Template-Toolkit [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 183b
I reckon that the .split method in the Template-Toolkit language should preserve its present behaviour of always treating a delimiter parameter as a regexp. Patch attached. -zefram
Download split_pattern.patch
text/x-diff 956b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 195b
A quick note to mention that this change is still present in 5.18.0-RC2, and as a result Template-Toolkit is currently not installable there. (well, can always skip tests, but in the simple case)
Download (untitled) / with headers
text/plain 209b
I am not quite sure what the failing test is doing. If I skip this test in order to install Template-Toolkit, what are the potential results? Should I skip tests for Template-Toolkit until the issue is fixed?
Download (untitled) / with headers
text/plain 290b
On Mon Apr 22 13:06:43 2013, zefram@fysh.org wrote: Show quoted text
> I reckon that the .split method in the Template-Toolkit language should > preserve its present behaviour of always treating a delimiter parameter > as a regexp. Patch attached. > > -zefram
+1 I'm all for preserving present behaviour
Download (untitled) / with headers
text/plain 166b
Looks like Jon Jensen applied a patch for this back on May 24 2013: https://github.com/abw/Template2/commit/0caac1347e2e3f So this ticket and 86258 can be closed.
From: dsteinbrunner [...] pobox.com
Download (untitled) / with headers
text/plain 290b
On Wed Jul 03 19:41:51 2013, JHANNAH wrote: Show quoted text
> Looks like Jon Jensen applied a patch for this back on May 24 2013: > > https://github.com/abw/Template2/commit/0caac1347e2e3f > > So this ticket and 86258 can be closed.
I would close the dups but keep this one open till a release is cut.
Download (untitled) / with headers
text/plain 519b
On Fri Jul 05 18:15:52 2013, dsteinbrunner@pobox.com wrote: Show quoted text
> On Wed Jul 03 19:41:51 2013, JHANNAH wrote:
> > Looks like Jon Jensen applied a patch for this back on May 24 2013: > > > > https://github.com/abw/Template2/commit/0caac1347e2e3f > > > > So this ticket and 86258 can be closed.
> > I would close the dups but keep this one open till a release is cut.
Agreed -- closed "fixed" tickets seems to fall off the radar, and this one is still causing test failures for those of us moving environments to 5.18.
From: dsteinbrunner [...] pobox.com
Download (untitled) / with headers
text/plain 456b
On Fri Jul 05 18:15:52 2013, dsteinbrunner@pobox.com wrote: Show quoted text
> On Wed Jul 03 19:41:51 2013, JHANNAH wrote:
> > Looks like Jon Jensen applied a patch for this back on May 24 2013: > > > > https://github.com/abw/Template2/commit/0caac1347e2e3f > > > > So this ticket and 86258 can be closed.
> > I would close the dups but keep this one open till a release is cut.
Template::Toolkit 2.25 released... this ticket and its dups should be able to be closed.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.