Skip Menu |
 

This queue is for tickets about the Catalyst-Devel CPAN distribution.

Report information
The Basics
Id: 84613
Status: resolved
Priority: 0/
Queue: Catalyst-Devel

People
Owner: bobtfish [...] bobtfish.net
Requestors: marcel [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.38
Fixed in: (no value)



Subject: POD tests fail for generated app if author name contains umlaut
Download (untitled) / with headers
text/plain 1.6k
getpwuid(), used by Catalyst::Helper, returns "Marcel Grünauer" in my case. This produces the following errors: t/generated_app.t ................. 48/? # Failed test 'POD test for blib/lib/TestApp.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp.pm (67): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 # Failed test 'POD test for blib/lib/TestApp/Controller/MyController.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp/Controller/MyController.pm (33): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 # Failed test 'POD test for blib/lib/TestApp/Controller/Root.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp/Controller/Root.pm (58): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 # Failed test 'POD test for blib/lib/TestApp/Model/MyModel.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp/Model/MyModel.pm (17): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 # Failed test 'POD test for blib/lib/TestApp/View/MyView.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp/View/MyView.pm (17): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 # Looks like you failed 5 tests of 10. # Failed test 'Generated app test: t/02pod.t' # at t/generated_app.t line 211.
Download (untitled) / with headers
text/plain 392b
Thanks for the bug report Marcel. I've pushed a change which I _think_ should fix this issue, and I'd be most obliged if you could test it for me? git://git.shadowcat.co.uk/catagits/Catalyst-Devel # The change is in the 'master' branch. Please let me know if this doesn't resolve the issue? I'm going to assume that all is now good, and resolve this ticket unless I hear different however.
Subject: Re: [rt.cpan.org #84613] POD tests fail for generated app if author name contains umlaut
Date: Sun, 14 Apr 2013 00:28:17 +0200
To: bug-Catalyst-Devel [...] rt.cpan.org
From: Marcel Grünauer <hanekomu [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
Hi, On H.25/04/14, at 0:22, "Tomas Doran via RT" <bug-Catalyst-Devel@rt.cpan.org> wrote: Show quoted text
> I've pushed a change which I _think_ should fix this issue, and I'd be most obliged if you could test it for me? > > git://git.shadowcat.co.uk/catagits/Catalyst-Devel # The change is in the 'master' branch.
Thanks for the fast reply! It fixes most occurrences of that bug, but one remains: ok 48 - Generated app test: t/01app.t 1..10 ok 1 - POD test for blib/lib/TestApp.pm ok 2 - POD test for blib/lib/TestApp/Controller/MyController.pm not ok 3 - POD test for blib/lib/TestApp/Controller/Root.pm # Failed test 'POD test for blib/lib/TestApp/Controller/Root.pm' # at /Users/marcel/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod.pm line 186. # blib/lib/TestApp/Controller/Root.pm (58): Non-ASCII character seen before =encoding in 'Gr�nauer'. Assuming UTF-8 ok 4 - POD test for blib/lib/TestApp/Model/MyModel.pm ok 5 - POD test for blib/lib/TestApp/View/MyView.pm ok 6 - POD test for blib/script/testapp_cgi.pl ok 7 - POD test for blib/script/testapp_create.pl ok 8 - POD test for blib/script/testapp_fastcgi.pl ok 9 - POD test for blib/script/testapp_server.pl ok 10 - POD test for blib/script/testapp_test.pl # Looks like you failed 1 test of 10. not ok 49 - Generated app test: t/02pod.t Marcel
Download (untitled) / with headers
text/plain 201b
On Sat Apr 13 18:28:35 2013, hanekomu@gmail.com wrote: Show quoted text
> It fixes most occurrences of that bug, but one remains:
Whoops! I managed to miss one template. I've fixed this now, so we should be all good!
Subject: Re: [rt.cpan.org #84613] POD tests fail for generated app if author name contains umlaut
Date: Sun, 14 Apr 2013 00:31:05 +0200
To: bug-Catalyst-Devel [...] rt.cpan.org
From: Marcel Grünauer <hanekomu [...] gmail.com>
Download (untitled) / with headers
text/plain 222b
On H.25/04/14, at 0:30, "Tomas Doran via RT" <bug-Catalyst-Devel@rt.cpan.org> wrote: Show quoted text
> Whoops! I managed to miss one template. > > I've fixed this now, so we should be all good!
Yes, the test works now. Thanks! Marcel


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.