Skip Menu |
 

This queue is for tickets about the XML-SemanticDiff CPAN distribution.

Report information
The Basics
Id: 84546
Status: resolved
Priority: 0/
Queue: XML-SemanticDiff

People
Owner: Nobody in particular
Requestors: Nicholas.Phillips [...] computershare.com.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Zero node value treated as undefined or missing
Date: Wed, 10 Apr 2013 16:11:58 +1000
To: "bug-XML-SemanticDiff [...] rt.cpan.org" <bug-XML-SemanticDiff [...] rt.cpan.org>
From: Nicholas Phillips <Nicholas.Phillips [...] computershare.com.au>
Download (untitled) / with headers
text/plain 812b
I'm not sure if this module is still active, but I found a minor bug. If a node's text is the value zero, e.g. <weight>0</weight>, it is treated as empty/undefined. I made a quick fix to my copy as shown below. In sub Text: Before: $self->char_accumulator()->{$element} .= $char if $char; After: $self->char_accumulator()->{$element} .= $char if defined($char); In sub EndTag: Before: $text ||= 'o'; After: Removed - the MD5 encode function will treat the undefined string the same as an empty string which is fine for my purposes. Thanks, Nick --- This email may contain confidential information and is for the sole use of the intended recipient(s).  Any unauthorized use or disclosure of this communication is prohibited.  If you have received this email in error please delete it and notify sender.
Download (untitled) / with headers
text/plain 1.1k
Hi Nicholas, please submit a pull request to: https://bitbucket.org/shlomif/perl-xml-semanticdiff See: http://www.shlomifish.org/open-source/resources/how-to-contribute-to-my-projects/ for the guidelines. Regards, — Shlomi Fish On Wed Apr 10 02:12:24 2013, Nicholas.Phillips@computershare.com.au wrote: Show quoted text
> I'm not sure if this module is still active, but I found a minor bug. > > If a node's text is the value zero, e.g. <weight>0</weight>, it is > treated as empty/undefined. > > I made a quick fix to my copy as shown below. > > In sub Text: > > Before: $self->char_accumulator()->{$element} .= $char if $char; > After: $self->char_accumulator()->{$element} .= $char if > defined($char); > > In sub EndTag: > > Before: $text ||= 'o'; > After: Removed - the MD5 encode function will treat the undefined > string the same as an empty string which is fine for my purposes. > > Thanks, > Nick > > --- > This email may contain confidential information and is for the sole > use of the intended recipient(s).  Any unauthorized use or > disclosure of this communication is prohibited.  If you have > received this email in error please delete it and notify sender.
Subject: RE: [rt.cpan.org #84546] Zero node value treated as undefined or missing
Date: Fri, 12 Apr 2013 12:54:34 +1000
To: "bug-XML-SemanticDiff [...] rt.cpan.org" <bug-XML-SemanticDiff [...] rt.cpan.org>
From: Nicholas Phillips <Nicholas.Phillips [...] computershare.com.au>
Download (untitled) / with headers
text/plain 1.9k
Hi Shlomi, I've just coded and submitted the pull request - let me know if there are any issues, I have never worked with these systems before. I also bumped the version to 1.0001 but not sure if you want that. Thanks, Nick Show quoted text
-----Original Message----- From: Shlomi Fish via RT [mailto:bug-XML-SemanticDiff@rt.cpan.org] Sent: Friday, 12 April 2013 4:45 AM To: Nicholas Phillips Subject: [rt.cpan.org #84546] Zero node value treated as undefined or missing <URL: https://rt.cpan.org/Ticket/Display.html?id=84546 > Hi Nicholas, please submit a pull request to: https://bitbucket.org/shlomif/perl-xml-semanticdiff See: http://www.shlomifish.org/open-source/resources/how-to-contribute-to-my-projects/ for the guidelines. Regards, — Shlomi Fish On Wed Apr 10 02:12:24 2013, Nicholas.Phillips@computershare.com.au wrote:
> I'm not sure if this module is still active, but I found a minor bug. > > If a node's text is the value zero, e.g. <weight>0</weight>, it is > treated as empty/undefined. > > I made a quick fix to my copy as shown below. > > In sub Text: > > Before: $self->char_accumulator()->{$element} .= $char if $char; > After: $self->char_accumulator()->{$element} .= $char if > defined($char); > > In sub EndTag: > > Before: $text ||= 'o'; > After: Removed - the MD5 encode function will treat the undefined > string the same as an empty string which is fine for my purposes. > > Thanks, > Nick > > --- > This email may contain confidential information and is for the sole > use of the intended recipient(s).  Any unauthorized use or > disclosure of this communication is prohibited.  If you have > received this email in error please delete it and notify sender.
--- This email may contain confidential information and is for the sole use of the intended recipient(s).  Any unauthorized use or disclosure of this communication is prohibited.  If you have received this email in error please delete it and notify sender.
this was resolved.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.