Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the Spreadsheet-XLSX CPAN distribution.

Report information
The Basics
Id: 84528
Status: new
Priority: 0/
Queue: Spreadsheet-XLSX

People
Owner: Nobody in particular
Requestors: SVOELKEL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.13
Fixed in: (no value)



Subject: Use of uninitialized value $t in concatenation (.) or string at /usr/share/perl5/Spreadsheet/XLSX.pm line 49.
Download (untitled) / with headers
text/plain 827b
Not sure if this is the correct fix, but it doesn't visibly break for me: Index: libspreadsheet-xlsx-perl-0.13/lib/Spreadsheet/XLSX.pm =================================================================== --- libspreadsheet-xlsx-perl-0.13.orig/lib/Spreadsheet/XLSX.pm 2013-04-09 15:27:18.000000000 +0200 +++ libspreadsheet-xlsx-perl-0.13/lib/Spreadsheet/XLSX.pm 2013-04-09 15:27:22.000000000 +0200 @@ -43,10 +43,10 @@ my $mstr = $member_shared_strings->contents; $mstr =~ s/<t\/>/<t><\/t>/gsm; # this handles an empty t tag in the xml <t/> foreach my $si ($mstr =~ /<si.*?>(.*?)<\/si/gsm) { - my $str; + my $str = ''; foreach my $t ($si =~ /<t.*?>(.*?)<\/t/gsm) { $t = $converter -> convert ($t) if $converter; - $str .= $t; + $str .= $t if defined($t); } push @shared_strings, $str; }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.