Skip Menu |
 

This queue is for tickets about the Filter CPAN distribution.

Report information
The Basics
Id: 84405
Status: resolved
Priority: 0/
Queue: Filter

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.49
Fixed in: (no value)

Attachments


Subject: [PATCH] Redundant use of done_testing in POD coverage test
Download (untitled) / with headers
text/plain 514b
The use of done_testing() in the newly-added POD coverage test is redundant because all_pod_coverage_ok() define its own plan. If you really need to use it, a better test for its availability is to check for Test::More version 0.88 or later rather than checking for perl 5.8.6 or later. In case you're wondering, I (as a downstream packager) habitually run maintainer tests, not because they add value for the module I'm packaging at the time but to give wider testing for the maintainer test modules themselves.
Subject: Filter-1.49-done-testing.patch
--- t/z_pod-coverage.t +++ t/z_pod-coverage.t @@ -3,7 +3,6 @@ use warnings; use Test::More; -plan skip_all => 'done_testing requires 5.8.6' if $] <= 5.008005; plan skip_all => 'This test is only run for the module author' unless -d '.git' || $ENV{IS_MAINTAINER}; @@ -12,5 +11,3 @@ if $@; all_pod_coverage_ok(); - -done_testing();
Fixed with 1.50, thanks -- Reini Urban


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.