Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DateTime-Format-Strptime CPAN distribution.

Report information
The Basics
Id: 84371
Status: resolved
Priority: 0/
Queue: DateTime-Format-Strptime

People
Owner: Nobody in particular
Requestors: ALUCAS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: 1.53

Attachments


Subject: Tests failing (unexpected zero padding)
Download (untitled) / with headers
text/plain 440b
Hi, I think this module is no longer compatible with DateTime post version 1. This module has been failing for me on both Windows and Linux test boxes in the last few days. I've attached the build log. I think it has something to do with changes in DateTime (>= v1). The test fails because it's now receiving stray zeros. Any ideas? I noticed there have been some changes specifically around zero padding in the latest DateTime releases.
Subject: datetime_strptime_fail.build.log

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 755b
It seems that the zero padding is intentional in DateTime 1.00. I did a bisect on DateTime, and the commit that breaks this test (in Strptime) is: commit 32464cf62dc9d8c1c9282cee33a30248bd3f8aa5 Author: chansen <chansen@cpan.org> Date: Sat Mar 30 23:14:23 2013 +0100 Fixed the %j conversion specification in ->strftime to return the correct value %j should be padded with zeros if the day of the year is < 100, this matches the DateTime documentation and the POSIX specification which says: Replaced by the day of the year as a decimal number [001,366]. [ tm_yday] So it seems that the test should be patched to expect '2003;056 = 2003-02-25' instead of '2003;56 = 2003-02-25', and Strptime dist should require DateTime >= 1.00
Subject: Re: [rt.cpan.org #84371] Tests failing (unexpected zero padding)
Date: Tue, 2 Apr 2013 09:45:13 -0500 (CDT)
To: MSCHOUT via RT <bug-DateTime-Format-Strptime [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
Download (untitled) / with headers
text/plain 592b
On Tue, 2 Apr 2013, MSCHOUT via RT wrote: Show quoted text
> Queue: DateTime-Format-Strptime > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=84371 > > > It seems that the zero padding is intentional in DateTime 1.00. I did a bisect on DateTime, and the commit that breaks this test (in Strptime) is:
I release a new DT::F::Strptime with a fix. /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
I see you already fixed for v1.53 :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.