Skip Menu |
 

This queue is for tickets about the Crypt-Blowfish CPAN distribution.

Report information
The Basics
Id: 83924
Status: resolved
Priority: 0/
Queue: Crypt-Blowfish

People
Owner: DPARIS [...] cpan.org
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: SvUPGRADE usage change
Date: Wed, 13 Mar 2013 14:57:11 +0000
To: bug-Crypt-Blowfish [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 176b
SvUPGRADE() can't be used as a truth-value expression in current perl. It never actually returned false, so there's no need for the conditional. Attached patch fixes. -zefram
Download svupgrade.patch
text/x-diff 415b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 535b
On Wed Mar 13 07:57:29 2013, zefram@fysh.org wrote: Show quoted text
> SvUPGRADE() can't be used as a truth-value expression in current perl. > It never actually returned false, so there's no need for the conditional. > Attached patch fixes.
I've applied your patch and uploaded it as an unauthorized release, version number 2.12_001. I also emailed the author to let him know. Since it's been a couple months since this bug was reported, and since Perl 5.18 is now out (which is incompatible with the non-patched versions), it became more critical.
This ticket has been resolved in release 2.13 which has been uploaded to PAUSE. -dsp


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.