Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 83446
Status: new
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: EDAVIS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.118
Fixed in: (no value)



Subject: Perl::Critic::Utils::all_perl_files option to skip symlinks
Download (untitled) / with headers
text/plain 841b
all_perl_files('.') will recurse into subdirectories, including symlinks. This can be slow if you have a symlink to some big directory. It would be useful to have an option to not follow symlinks. Clearly the code change is simple, but a good interface for it is trickier. Currently all_perl_files takes a list of directory names; perhaps if the first argument is a code ref, it is used to filter directories: @files = all_perl_files sub { not(-l $_[0]) }, '.'; Would you consider adding that enhancement to the library? For the perlcritic command line tool, I'm tempted to say it should print a warning message such as Looking inside symbolic-linked directories, such as ./foo if it finds such a thing and --quiet is not set. Then nobody would wonder why a perlcritic run that used to run quickly is now apparently hanging.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.