Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 83365
Status: rejected
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: KOCEASY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Problem is in CGI/Util.pm when last rearranged param doesn't have any value.
Download (untitled) / with headers
text/plain 182b
There is problem in method rearrange, when is last or any value empty(undef). If is value undefined that can be printed in this format: <form method="post" action="/index.pl" id>
Subject: cgi.diff
Download cgi.diff
text/x-diff 410b
--- CGI/Util.pm~ 2013-02-16 02:31:28.925631427 +0100 +++ CGI/Util.pm 2013-02-16 02:31:52.117928210 +0100 @@ -116,9 +116,9 @@ my $key = lc(shift(@param)); $key =~ s/^\-//; if (exists $pos{$key}) { - $result[$pos{$key}] = shift(@param); + $result[$pos{$key}] = (shift(@param) || next); } else { - $leftover{$key} = shift(@param); + $leftover{$key} = (shift(@param) || next); } }
Subject: Re: [rt.cpan.org #83365] Problem is in CGI/Util.pm when last rearranged param doesn't have any value.
Date: Thu, 21 Feb 2013 09:43:43 -0500
To: bug-cgi.pm [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Download (untitled) / with headers
text/plain 299b
Thanks for the feedback. Could you also submit an automated test for the test suite which illustrates the problem. Also, a Github a pull request would be helpful. Those things will help speed up the acceptance and merging. Accept changes will include credit the Changes file. Thanks, Mark
Download (untitled) / with headers
text/plain 241b
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/114 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
The small patch in the original report causes some test failures: ``` Test Summary Report ------------------- t/function.t (Wstat: 0 Tests: 32 Failed: 1) Failed test: 25 t/headers/charset.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 t/headers/type.t (Wstat: 512 Tests: 7 Failed: 2) Failed tests: 2, 5 Non-zero exit status: 2 t/html.t (Wstat: 512 Tests: 40 Failed: 2) Failed tests: 10-11 Non-zero exit status: 2 t/popup_menu.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 t/url.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=50, Tests=762, 5 wallclock secs ( 0.24 usr 0.13 sys + 1.68 cusr 0.28 csys = 2.33 CPU) Result: FAIL Failed 6/50 test programs. 8/762 subtests failed. make: *** [test_dynamic] Error 255 ``` If the OG reporter can provide a pull request that fixes this issue with tests and no regressions i'm happy to accept it, otherwise i will close this issue shortly.
Closing due to lack of response.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.