Skip Menu |
 

This queue is for tickets about the Memory-Usage CPAN distribution.

Report information
The Basics
Id: 83323
Status: open
Priority: 0/
Queue: Memory-Usage

People
Owner: Nobody in particular
Requestors: mlx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.201
Fixed in: (no value)



Subject: Mark certain OS as unsupported
Download (untitled) / with headers
text/plain 809b
The module does not 'fail early' on unsupported platforms. Please update the Makefile.PL and the module documentation to state that it is only supported on BLAH BLAH platforms. In Makefile.PL: die("No support for OS\n") if $^O ...; Perhaps something more generic (testing if the interface to the memory system used, for example) would be more appropriate, but that is an implementation detail. Something similar should also be in place _early_ in the module load process within the Memory/Usage.pm file. Also update README and module documentation with something to the effect of: This module makes use of the proc file system, specifically /proc/$pid/statm. Unless your system supports that interface, this module is unsupported. Examples of supported environments are ... --MLX
Download (untitled) / with headers
text/plain 1.3k
On 2013-02-14 12:00:54, midlifexis@wightmanfam.org wrote: Show quoted text
> The module does not 'fail early' on unsupported platforms. Please > update the Makefile.PL and the module documentation to state that it is > only supported on BLAH BLAH platforms. > > In Makefile.PL: > > die("No support for OS\n") if $^O ...; > > Perhaps something more generic (testing if the interface to the memory > system used, for example) would be more appropriate, but that is an > implementation detail. > > Something similar should also be in place _early_ in the module load > process within the Memory/Usage.pm file. > > Also update README and module documentation with something to the effect of: > > This module makes use of the proc file system, > specifically /proc/$pid/statm. Unless your system > supports that interface, this module is unsupported. > Examples of supported environments are ... > > --MLX
Yes, please. By looking at testers results http://matrix.cpantesters.org/?dist=Memory-Usage+0.201 one would think that the module works everywhere. And if Memory::Usage is used on a system without procfs, then a non-informative error message is printed: No such file or directory at /usr/perl5.20.2p/lib/site_perl/5.20.2/Memory/Usage.pm line 77. It would at least help if the name of the file was printed here...


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.