Skip Menu |
 

This queue is for tickets about the Dist-Zilla-Plugin-ReadmeFromPod CPAN distribution.

Report information
The Basics
Id: 83271
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-ReadmeFromPod

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Don't blindly replace any 'README' found
Download (untitled) / with headers
text/plain 219b
I had a t/README readme and it was replaced on build by the generated README file. That was completely surprising. I would eliminate that mis-feature or at least constrain it to the root directory of the distribution.
Download (untitled) / with headers
text/plain 525b
On Mon Feb 11 13:15:12 2013, DAGOLDEN wrote: Show quoted text
> I had a t/README readme and it was replaced on build by the generated > README file. That was completely surprising. > > I would eliminate that mis-feature or at least constrain it to the root > directory of the distribution.
Indeed, that does seem surprising! I will try to look into this later tonight. In the meantime, can you post the relevant piece of dist.ini you're using to configure the ReadmeFromPod plugin? (maybe even better to post the whole config if you can)
Download (untitled) / with headers
text/plain 149b
I added ^ in the matching code which should fix this issue. my $file = $self->zilla->files->grep( sub { $_->name =~ m{^README\z} } )->head; Thanks.
Subject: Re: [rt.cpan.org #83271] Don't blindly replace any 'README' found
Date: Mon, 11 Feb 2013 22:57:25 -0500
To: bug-Dist-Zilla-Plugin-ReadmeFromPod [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 705b
On Mon, Feb 11, 2013 at 10:09 PM, Fayland Lin via RT <bug-Dist-Zilla-Plugin-ReadmeFromPod@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=83271 > > > I added ^ in the matching code which should fix this issue. > > my $file = $self->zilla->files->grep( sub { $_->name =~ m{^README\z} } )->head;
That's equivalent to just specifying "README" just as if $file was undef. The only thing that changes is that a different log message is generated. That would fix *my* issue, but you might want to consider if that's why that code needed to be there in the first place. David -- David Golden <dagolden@cpan.org> Take back your inbox! → http://www.bunchmail.com/ Twitter/IRC: @xdg


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.