Skip Menu |
 

This queue is for tickets about the Crypt-DES CPAN distribution.

Report information
The Basics
Id: 82943
Status: resolved
Priority: 0/
Queue: Crypt-DES

People
Owner: DPARIS [...] cpan.org
Requestors: felliott [...] virginia.edu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Crypt::DES fails to compile on perl-5.17.8
Download (untitled) / with headers
text/plain 3.9k
Hello, Crypt::DES v2.05 fails to compile on perl-5.17.8 with the following error message: ---- Building and testing Crypt-DES-2.05 cp DES.pm blib/lib/Crypt/DES.pm /Users/fge7z/perl5/perlbrew/perls/perl-5.17.8/bin/perl5.17.8 /Users/fge7z/perl5/perlbrew/perls/perl-5.17.8/lib/5.17.8/ExtUtils/xsubpp -typemap /Users/fge7z/perl5/perlbrew/perls/perl-5.17.8/lib/5.17.8/ExtUtils/typemap -typemap typemap\ DES.xs > DES.xsc && mv DES.xsc DES.c cc -c -fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector - I/usr/local/include -O3 -DVERSION=\"2.05\" -DXS_VERSION=\"2.05\" "- I/Users/fge7z/perl5/perlbrew/perls/perl-5.17.8/lib/5.17.8/darwin-2level/CORE" DES.\ c DES.xs: In function ‘XS_Crypt__DES_crypt’: DES.xs:67: error: wrong type argument to unary exclamation mark make: *** [DES.o] Error 1 -> FAIL Installing Crypt::DES failed. See /Users/fge7z/.cpanm/build.log for details. ---- That error corresponds to this line in DES.xs: ---- if (!SvUPGRADE(output, SVt_PV)) croak("cannot use output argument as lvalue"); ---- Searching the perl git log for SvUPGRADE turned up this commit: ---- commit 463ea2290a54ee65470ca4dd46dea0d41cfbc9dd Author: David Mitchell <davem@iabyn.com> Date: Fri Dec 14 15:05:40 2012 +0000 make SvUPGRADE() a statement. To guote the perldelta entry: SvUPGRADE() is no longer an expression. Originally this macro (and its underlying function, sv_upgrade()) were documented as boolean, although in reality they always croaked on error and never returned false. In 2005 the documentation was updated to specify a void return value, but SvUPGRADE() was left always returning 1 for backwards compatibility. This has now been removed, and SvUPGRADE() is now a statement with no return value. So this is now a syntax error: if (!SvUPGRADE(sv)) { croak(...); } If you have code like that, simply replace it with SvUPGRADE(sv); ---- I replaced the problem line in DES.xs as suggested in the commit message and the module compiled and tested fine. I don't actually know anything about XS, so can't say for sure this is the correct fix, but it seems to work and all the modules that I was installing that depend on Crypt::DES passed their tests as well. Thank you for your time and hard work on this module and have a great weekend! Cheers, Fitz Elliott
Subject: Re: [rt.cpan.org #82943] Crypt::DES fails to compile on perl-5.17.8
Date: Wed, 13 Mar 2013 15:04:42 +0000
To: bug-Crypt-DES [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Attached patch fixes. -zefram
Download svupgrade.patch
text/x-diff 368b

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 232b
I've applied the patch that has been supplied earlier in this thread, and uploaded an "unauthorized release" as v2.05_001. This version will work on Perl 5.18.0. Hopefully an official release will come from the maintainer soonish.
Download (untitled) / with headers
text/plain 250b
Dear maintainer, could you please apply the patch for this ticket and make a new release? Thank you. Alternatively, if you don't have time to continue as maintainer, please let us know and we'll find a volunteer to take over. Regards, David Golden
RT-Send-CC: zefram [...] fysh.org, a-mused [...] pobox.com, dagolden [...] cpan.org
Download (untitled) / with headers
text/plain 461b
On Thu Jun 06 15:29:47 2013, DAGOLDEN wrote: Show quoted text
> Dear maintainer, could you please apply the patch for this ticket and > make a new release? Thank you. > > Alternatively, if you don't have time to continue as maintainer, > please let us know and we'll find a volunteer to take over. > > Regards, > David Golden
It's been a couple months since this patch was made and re-pinged; should we forward this on to the modules@cpan.org list and get it taken care of?
CC: zefram [...] fysh.org, a-mused [...] pobox.com, dagolden [...] cpan.org
Subject: Re: [rt.cpan.org #82943] Crypt::DES fails to compile on perl-5.17.8
Date: Tue, 23 Jul 2013 10:56:05 +0100
To: Frew Schmidt via RT <bug-Crypt-DES [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 210b
Frew Schmidt via RT wrote: Show quoted text
>It's been a couple months since this patch was made and re-pinged; should >we forward this on to the modules@cpan.org list and get it taken care of?
Seems a bit premature. -zefram
Download (untitled) / with headers
text/plain 417b
On Mon Jul 22 20:22:34 2013, frew wrote: Show quoted text
> It's been a couple months since this patch was made and re-pinged; > should we forward this on to the modules@cpan.org list and get it > taken care of?
I'll try a direct email appeal first (not via RT). If there's no response within another week or two and if a volunteer appears, I would support a co-maint takeover appeal. David (speaking as user, not as a PAUSE admin)
RT-Send-CC: dagolden [...] cpan.org, zefram [...] fysh.org
This ticket has been resolved in release 2.06 which has been uploaded to PAUSE. -dsp
Download (untitled) / with headers
text/plain 2.5k
On Tue Jul 23 11:50:14 2013, DPARIS wrote: Show quoted text
> This ticket has been resolved in release 2.06 which has been uploaded > to PAUSE. > > -dsp
That also fails to build: Fetching http://www.cpan.org/authors/id/D/DP/DPARIS/Crypt-DES-2.06.tar.gz ... OK Unpacking Crypt-DES-2.06.tar.gz Crypt-DES-2.06/ Crypt-DES-2.06/MANIFEST Crypt-DES-2.06/DES.xs Crypt-DES-2.06/README Crypt-DES-2.06/_des.c Crypt-DES-2.06/test.pl Crypt-DES-2.06/Makefile.PL Crypt-DES-2.06/DES.pm Crypt-DES-2.06/COPYRIGHT Crypt-DES-2.06/META.yml Crypt-DES-2.06/_des.h Crypt-DES-2.06/typemap Entering Crypt-DES-2.06 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.66) Configuring Crypt-DES-2.06 ... Running Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Crypt::DES Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.66) Building and testing Crypt-DES-2.06 ... cp DES.pm blib/lib/Crypt/DES.pm /home/frew/perl5/perlbrew/perls/perl-5.18.0/bin/perl /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/ExtUtils/xsubpp -typemap /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/ExtUtils/typemap -typemap typemap DES.xs > DES.xsc && mv DES.xsc DES.c cc -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"2.06\" -DXS_VERSION=\"2.06\" -fPIC "-I/home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/CORE" DES.c cc -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"2.06\" -DXS_VERSION=\"2.06\" -fPIC "-I/home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/CORE" _des.c Running Mkbootstrap for Crypt::DES () chmod 644 DES.bs rm -f blib/arch/auto/Crypt/DES/DES.so cc -shared -O2 -L/usr/local/lib -L/opt/local/lib -fstack-protector DES.o _des.o -o blib/arch/auto/Crypt/DES/DES.so \ \ chmod 755 blib/arch/auto/Crypt/DES/DES.so cp DES.bs blib/arch/auto/Crypt/DES/DES.bs chmod 644 blib/arch/auto/Crypt/DES/DES.bs Manifying blib/man3/Crypt::DES.3 PERL_DL_NONLAZY=1 /home/frew/perl5/perlbrew/perls/perl-5.18.0/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl Crypt::DES object version 2.06 does not match $Crypt::DES::VERSION 2.05 at /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/DynaLoader.pm line 213. make: *** [test_dynamic] Error 2 FAIL ! Installing Crypt::DES failed. See /home/frew/.cpanm/build.log for details.
Subject: Re: [rt.cpan.org #82943] Crypt::DES fails to compile on perl-5.17.8
Date: Tue, 23 Jul 2013 20:41:35 +0000
To: bug-Crypt-DES [...] rt.cpan.org
From: Dave Paris <dparis [...] w3works.com>
Download (untitled) / with headers
text/plain 2.7k
Fixed. 2.07 uploaded to PAUSE. -dsp On 7/23/2013 8:02 PM, Frew Schmidt via RT wrote: Show quoted text
> Queue: Crypt-DES > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82943 > > > On Tue Jul 23 11:50:14 2013, DPARIS wrote:
>> This ticket has been resolved in release 2.06 which has been uploaded >> to PAUSE. >> >> -dsp
> > > That also fails to build: > > Fetching http://www.cpan.org/authors/id/D/DP/DPARIS/Crypt-DES-2.06.tar.gz ... OK > Unpacking Crypt-DES-2.06.tar.gz > Crypt-DES-2.06/ > Crypt-DES-2.06/MANIFEST > Crypt-DES-2.06/DES.xs > Crypt-DES-2.06/README > Crypt-DES-2.06/_des.c > Crypt-DES-2.06/test.pl > Crypt-DES-2.06/Makefile.PL > Crypt-DES-2.06/DES.pm > Crypt-DES-2.06/COPYRIGHT > Crypt-DES-2.06/META.yml > Crypt-DES-2.06/_des.h > Crypt-DES-2.06/typemap > Entering Crypt-DES-2.06 > Checking configure dependencies from META.yml > Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.66) > Configuring Crypt-DES-2.06 ... Running Makefile.PL > Checking if your kit is complete... > Looks good > Writing Makefile for Crypt::DES > Writing MYMETA.yml and MYMETA.json > OK > Checking dependencies from MYMETA.json ... > Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.66) > Building and testing Crypt-DES-2.06 ... cp DES.pm blib/lib/Crypt/DES.pm > /home/frew/perl5/perlbrew/perls/perl-5.18.0/bin/perl /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/ExtUtils/xsubpp -typemap /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/ExtUtils/typemap -typemap typemap DES.xs > DES.xsc && mv DES.xsc DES.c > cc -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"2.06\" -DXS_VERSION=\"2.06\" -fPIC "-I/home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/CORE" DES.c > cc -c -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"2.06\" -DXS_VERSION=\"2.06\" -fPIC "-I/home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/CORE" _des.c > Running Mkbootstrap for Crypt::DES () > chmod 644 DES.bs > rm -f blib/arch/auto/Crypt/DES/DES.so > cc -shared -O2 -L/usr/local/lib -L/opt/local/lib -fstack-protector DES.o _des.o -o blib/arch/auto/Crypt/DES/DES.so \ > \ > > chmod 755 blib/arch/auto/Crypt/DES/DES.so > cp DES.bs blib/arch/auto/Crypt/DES/DES.bs > chmod 644 blib/arch/auto/Crypt/DES/DES.bs > Manifying blib/man3/Crypt::DES.3 > PERL_DL_NONLAZY=1 /home/frew/perl5/perlbrew/perls/perl-5.18.0/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl > Crypt::DES object version 2.06 does not match $Crypt::DES::VERSION 2.05 at /home/frew/perl5/perlbrew/perls/perl-5.18.0/lib/5.18.0/x86_64-linux/DynaLoader.pm line 213. > make: *** [test_dynamic] Error 2 > FAIL > ! Installing Crypt::DES failed. See /home/frew/.cpanm/build.log for details. >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.