Skip Menu |
 

This queue is for tickets about the Template-Declare CPAN distribution.

Report information
The Basics
Id: 82171
Status: resolved
Priority: 0/
Queue: Template-Declare

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.45
Fixed in: (no value)



Subject: Random failure of smart_tag_wrapper.t on 5.17.x ( might be hash-order dependent )

Randomly it gets

 

<form id="edit_prefs" action="edit.html">

 

instead of 

 

<form action="edit.html" id="edit_prefs">

 

And this sounds like a likely 5.17.x hash-order randomization based failure ( ie: erroneously depending on an implicit hash order on pre 5.17 perls )

I skimmed the code, but couldn't see anything to the effect of "By design" or work out exactly where its going wrong, so it might not  hash randomization based.

 

 

not ok 4 - got correct output for simple


Show quoted text
#   Failed test 'got correct output for simple'
#   at t/smart_tag_wrapper.t line 87.
#          got: '
#
# <form id="edit_prefs" action="edit.html">
#  <label>Time Zone</label>
#  <input type="text" name="tz" />
#  <input type="submit" value="Save" />
# </form>'
#     expected: '
#
# <form action="edit.html" id="edit_prefs">
#  <label>Time Zone</label>
#  <input type="text" name="tz" />
#  <input type="submit" value="Save" />
# </form>'
# Looks like you failed 1 test of 4.

Subject: Re: [rt.cpan.org #82171] Random failure of smart_tag_wrapper.t on 5.17.x ( might be hash-order dependent )
Date: Sat, 22 Dec 2012 15:59:54 +0400
To: bug-Template-Declare [...] rt.cpan.org
From: Ruslan Zakirov <ruslan.zakirov [...] gmail.com>
Download (untitled) / with headers
text/plain 1.6k
Sure looks like hash randomization bug. Attributes are stored in a hash before final rendering. Will look into it unless someone beat me. Ruslan from phone. 22.12.2012 15:48 пользователь "Kent Fredric via RT" < bug-Template-Declare@rt.cpan.org> написал: Show quoted text
> > Sat Dec 22 06:48:12 2012: Request 82171 was acted upon. > Transaction: Ticket created by KENTNL > Queue: Template-Declare > Subject: Random failure of smart_tag_wrapper.t on 5.17.x ( might be > hash-order dependent ) > Broken in: 0.45 > Severity: Normal > Owner: Nobody > Requestors: KENTNL@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82171 > > > > Randomly it gets > > <form id="edit_prefs" action="edit.html"> > > instead of > > <form action="edit.html" id="edit_prefs"> > > And this sounds like a likely 5.17.x hash-order randomization based
failure ( Show quoted text
> ie: erroneously depending on an implicit hash order on pre 5.17 perls ) > > I skimmed the code, but couldn't see anything to the effect of "By
design" or Show quoted text
> work out exactly where its going wrong, so it might not hash randomization > based. > > not ok 4 - got correct output for simple > > > # Failed test 'got correct output for simple' > # at t/smart_tag_wrapper.t line 87. > # got: ' > # > # <form id="edit_prefs" action="edit.html"> > # <label>Time Zone</label> > # <input type="text" name="tz" /> > # <input type="submit" value="Save" /> > # </form>' > # expected: ' > # > # <form action="edit.html" id="edit_prefs"> > # <label>Time Zone</label> > # <input type="text" name="tz" /> > # <input type="submit" value="Save" /> > # </form>' > # Looks like you failed 1 test of 4. >
Subject: Re: [rt.cpan.org #82171] Random failure of smart_tag_wrapper.t on 5.17.x ( might be hash-order dependent )
Date: Sun, 23 Dec 2012 19:50:16 -0500
To: bug-Template-Declare [...] rt.cpan.org
From: Alex Vandiver <alex [...] chmrr.net>
Download (untitled) / with headers
text/plain 289b
On Sat, 2012-12-22 at 07:00 -0500, Ruslan.Zakirov@gmail.com via RT wrote: Show quoted text
> Sure looks like hash randomization bug. Attributes are stored in a hash > before final rendering. Will look into it unless someone beat me.
Yup. Fixed in f4feea2 and released as Template-Declare-0.46. - Alex


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.