Skip Menu |
 

This queue is for tickets about the Net-DNS-ZoneFile-Fast CPAN distribution.

Report information
The Basics
Id: 81757
Status: resolved
Priority: 0/
Queue: Net-DNS-ZoneFile-Fast

People
Owner: wjhns117 [...] hardakers.net
Requestors: amiribarksdale [...] gmail.com
Cc: rsrchboy [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Net::DNS::RR::new_from_hash is gone
Download (untitled) / with headers
text/plain 114b
With Net::DNS> 0.69, this module fails to call a method Net::DNS::RR::new_from_hash, because it has been deleted!
From: rwfranks [...] acm.org
Download (untitled) / with headers
text/plain 1000b
On Thu Dec 06 19:57:51 2012, AMIRI wrote: Show quoted text
> With Net::DNS> 0.69, this module fails to call a method > Net::DNS::RR::new_from_hash, because it has been deleted!
new_from_hash() is not, and never has been, part of the published API. *** /home/rwf/src/Net-DNS-ZoneFile-Fast-1.17/Fast.pm 2012-09-24 22:43:37.000000000 +0100 --- ./Fast.pm 2012-12-28 10:51:20.842453323 +0000 *************** *** 198,205 **** $z->{mbox} = uc $z->{mbox} if defined $z->{mbox}; $z->{txtdname} = uc $z->{txtdname} if defined $z->{txtdname}; } ! my $newrec = ! Net::DNS::RR->new_from_hash(%$z); if ($newrec->{'type'} eq 'DNSKEY') { if (ref($newrec) ne 'Net::DNS::RR::DNSKEY') { --- 198,204 ---- $z->{mbox} = uc $z->{mbox} if defined $z->{mbox}; $z->{txtdname} = uc $z->{txtdname} if defined $z->{txtdname}; } ! my $newrec = Net::DNS::RR->new(%$z); if ($newrec->{'type'} eq 'DNSKEY') { if (ref($newrec) ne 'Net::DNS::RR::DNSKEY') {
Download (untitled) / with headers
text/plain 136b
I think the original author used it to avoid one unnecessary function in the stack. I've changed it for the next release to use new().
CC: amiribarksdale [...] gmail.com
Subject: Re: [rt.cpan.org #81757] Net::DNS::RR::new_from_hash is gone
Date: Wed, 2 Jan 2013 14:38:28 -0600
To: bug-Net-DNS-ZoneFile-Fast [...] rt.cpan.org
From: Chris Weyl <rsrchboy [...] cpan.org>
Download (untitled) / with headers
text/plain 391b
On Wed, Jan 2, 2013 at 12:51 PM, Wes Hardaker via RT < bug-Net-DNS-ZoneFile-Fast@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=81757 > > > I think the original author used it to avoid one unnecessary function in > the stack. I've changed it for the next release to use new(). >
Thanks! :) -Chris -- Chris Weyl Ex astris, scientia


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.