Skip Menu |
 

This queue is for tickets about the HTML-FillInForm CPAN distribution.

Report information
The Basics
Id: 81652
Status: resolved
Priority: 0/
Queue: HTML-FillInForm

People
Owner: MARKSTOS [...] cpan.org
Requestors: ANDK [...] cpan.org
Cc: chisel [...] chizography.net
AdminCc:

Bug Information
Severity: Important
Broken in: 2.1
Fixed in: (no value)



Subject: Test failures due to hash randomisation in perl 5.17.6
Download (untitled) / with headers
text/plain 572b
Since bleadperl v5.17.5-518-g7dc8663 your tests are failing frequently. That commit introduced hash key randomization and it seems at least the test t/26_invalid_fields.t is hit by that. Find a sample fail report at: http://www.cpantesters.org/cpan/report/618211a2-3194-11e2-96ca-71c5a290f8f5 You can read more about the change at http://perl5.git.perl.org/perl.git/commit/7dc8663964c66a698d31bbdc8e8abed69bddeec3 or at http://www.perlmonks.org/?node_id=1005122 You may have to run the test several times until the randomization causes a fail. HTH&&Thanks&&Regards,
Subject: Re: [rt.cpan.org #81652] Test failures due to hash randomisation in perl 5.17.6
Date: Mon, 03 Dec 2012 09:11:41 -0500
To: bug-html-fillinform [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
That's helpful, thanks.
Download (untitled) / with headers
text/plain 104b
Hi, Perl 5.18 was out, and HTML::FillInForm's test case still failing. Could you release new version?
Thanks for the nudge. I'll see if it's something fast I could push out today.
Download (untitled) / with headers
text/plain 385b
On Thu May 23 14:31:21 2013, MARKSTOS wrote: Show quoted text
> Thanks for the nudge. I'll see if it's something fast I could push out > today.
Is this something that's fixed and waiting a release, or needs a fix to be prepared first? If the latter, I can't find a repo link in the dist (https://metacpan.org/module/HTML::FillInForm) - do you prefer standalone patched over commits/cherry-picks, etc?
Subject: Re: [rt.cpan.org #81652] Test failures due to hash randomisation in perl 5.17.6
Date: Thu, 30 May 2013 14:03:15 -0400
To: bug-html-fillinform [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Download (untitled) / with headers
text/plain 278b
We still need the fix. You are right-- I can't find the official repo, either. (I'm a newer maintainer, not the author). Posting a "diff -u" here as an attachment here would be helpful, if you have the time. My new release target is sometime during YAPC. (Within the week).
RT-Send-CC: tjmather [...] maxmind.com
Download (untitled) / with headers
text/plain 383b
TJ, I have time to fix this during YAPC in the next few days. Is there a public repo for this? Would you prefer a diff to apply and release yourself, or would you like me to go ahead and push out a release myself. My plan would be to roll out a simple release that just includes the latest release, plus the critical fix for 5.18. I'll start working on the diff in the meantime.
Subject: Re: [rt.cpan.org #81652] Test failures due to hash randomisation in perl 5.17.6
Date: Mon, 03 Jun 2013 10:26:08 -0400
To: MARKSTOS via RT <bug-HTML-FillInForm [...] rt.cpan.org>
From: Thomas J Mather <tjmather [...] tjmather.com>
Download (untitled) / with headers
text/plain 739b
Hi Mark, I never created a public repo for this module, as far as I can remember, so it is possible there is no public repo. I think it would be ok to create a public repo for it if you wanted to. Thanks, -TJ On Mon, Jun 3, 2013, at 10:13 AM, MARKSTOS via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=81652 > > > TJ, > > I have time to fix this during YAPC in the next few days. > > Is there a public repo for this? Would you prefer a diff to apply and > release yourself, or would you like me to go ahead and push out a release > myself. > > My plan would be to roll out a simple release that just includes the > latest release, plus the critical fix for 5.18. > > I'll start working on the diff in the meantime.
Download (untitled) / with headers
text/plain 394b
On Mon Jun 03 10:26:28 2013, tjmather@tjmather.com wrote: Show quoted text
> Hi Mark, > > I never created a public repo for this module, as far as I can remember, > so it is possible there is no public repo. I think it would be ok to > create > a public repo for it if you wanted to.
OK, I'll put the latest release on GitHub then. We can work on getting the change history connected with it later. Mark
Subject: Test failures due to hash randomisation in perl 5.17.6 (New release)
RT-Send-CC: tjmather [...] maxmind.com, tjmather [...] maxmind.com
Download (untitled) / with headers
text/plain 230b
I've now released HTML::FillInForm 2.11 which addresses this issue. I also created a public repo for it on GitHub, and granted access to TJMATHER to this repo: https://github.com/markstos/HTML-FillInForm/commits/master Mark


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.