Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Hooks CPAN distribution.

Report information
The Basics
Id: 81435
Status: resolved
Priority: 0/
Queue: Git-Hooks

People
Owner: GNUSTAVO [...] cpan.org
Requestors: cpan [...] lxxi.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: get_affected_files() is broken
Download (untitled) / with headers
text/plain 415b
1. The methods wants a "new-commit" and an "old-commit" parameter, but both are discarded. 2. In my test repository, "git diff --cached --name-status" gives this output: D a_file But get_affected_files() produces a warning "Use of uninitialized value $name in hash element at ... Git/More.pm line 90" and a Dump of the returned data looks like this: $VAR1 = { '' => 'D a_file' };
Download (untitled) / with headers
text/plain 378b
Thank you. This routine (get_affected_files) was indeed broken and it wasn't used yet by any plugins. Yesterday I released v0.022 which includes another plugin (check-structure.pl). As it was going to use get_affected_files I realizes the problem. Then I decided to reimplement the routine in a more general way and renamed it to get_diff_files. I think it's working now.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.