Skip Menu |
 

This queue is for tickets about the libwww-perl CPAN distribution.

Report information
The Basics
Id: 81381
Status: resolved
Priority: 0/
Queue: libwww-perl

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Test failures due to hash randomisation in perl 5.17.6
Download (untitled) / with headers
text/plain 615b
Perl 5.17.6 randomises hash seeds, exposing an existing bug in t/base/ua.t: # Expected: "http://example.com" # base/ua.t line 101 is: ok($ua->proxy('http'), "http://example.com"); # Test 34 got: "http://10.10.10.2:8080" (base/ua.t at line 105) # Expected: "http://example.com" # base/ua.t line 105 is: ok($ua->proxy('http'), "http://example.com"); I happen to have HTTP_PROXY set to http://10.10.10.2:8080 and http_proxy unset. The test script sets http_proxy. Which of HTTP_PROXY and http_proxy is picked up by sub LWP::UserAgent::env_proxy is going to be random, so the test will fail half the time.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.2k
On Fri Nov 23 11:38:12 2012, SPROUT wrote: Show quoted text
> Perl 5.17.6 randomises hash seeds, exposing an existing bug in > t/base/ua.t: > > # Expected: "http://example.com" > # base/ua.t line 101 is: ok($ua->proxy('http'), > "http://example.com"); > # Test 34 got: "http://10.10.10.2:8080" (base/ua.t at line 105) > # Expected: "http://example.com" > # base/ua.t line 105 is: ok($ua->proxy('http'), > "http://example.com"); > > I happen to have HTTP_PROXY set to http://10.10.10.2:8080 and > http_proxy unset. > > The test script sets http_proxy. Which of HTTP_PROXY and http_proxy > is picked up by sub > LWP::UserAgent::env_proxy is going to be random, so the test will fail > half the time.
I just pushed: https://github.com/demerphq/libwww- perl/commit/96791d2f72dc20ab6ff3c6ce6442a8db509bcfcc and submitted a pull request: https://github.com/gisle/libwww-perl/pull/3 to have it merged to https://github.com/gisle/libwww-perl but i notice that itself is a fork of https://github.com/libwww-perl/libwww-perl which has a lot of pull requests of its own: https://github.com/libwww-perl/libwww-perl/pulls So I am unclear if i pushed my request to the right place. Anyway this is a major blocker for 5.18. https://github.com/gisle/libwww-perl/pull/3
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.3k
On Tue Nov 27 16:35:32 2012, YVES wrote: Show quoted text
> On Fri Nov 23 11:38:12 2012, SPROUT wrote:
> > Perl 5.17.6 randomises hash seeds, exposing an existing bug in > > t/base/ua.t: > > > > # Expected: "http://example.com" > > # base/ua.t line 101 is: ok($ua->proxy('http'), > > "http://example.com"); > > # Test 34 got: "http://10.10.10.2:8080" (base/ua.t at line 105) > > # Expected: "http://example.com" > > # base/ua.t line 105 is: ok($ua->proxy('http'), > > "http://example.com"); > > > > I happen to have HTTP_PROXY set to http://10.10.10.2:8080 and > > http_proxy unset. > > > > The test script sets http_proxy. Which of HTTP_PROXY and http_proxy > > is picked up by sub > > LWP::UserAgent::env_proxy is going to be random, so the test will fail > > half the time.
> > I just pushed: > > https://github.com/demerphq/libwww- > perl/commit/96791d2f72dc20ab6ff3c6ce6442a8db509bcfcc > > and submitted a pull request: > > https://github.com/gisle/libwww-perl/pull/3 > > to have it merged to > > https://github.com/gisle/libwww-perl > > but i notice that itself is a fork of > > https://github.com/libwww-perl/libwww-perl > > which has a lot of pull requests of its own: > > https://github.com/libwww-perl/libwww-perl/pulls > > So I am unclear if i pushed my request to the right place. > > Anyway this is a major blocker for 5.18. > > https://github.com/gisle/libwww-perl/pull/3
Thank you for beating me to it.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.