Skip Menu |
 

This queue is for tickets about the App-ArchiveDevelCover CPAN distribution.

Report information
The Basics
Id: 81092
Status: resolved
Priority: 0/
Queue: App-ArchiveDevelCover

People
Owner: domm [...] cpan.org
Requestors: hhn [...] jobindex.dk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Links to archived coverage and diff
Date: Sat, 10 Nov 2012 14:55:47 +0200
To: <bug-App-ArchiveDevelCover [...] rt.cpan.org>
From: Henrik Hald Nørgaard <hhn [...] jobindex.dk>
Download (untitled) / with headers
text/plain 1.1k
The links in the archive index.shtml - file look like this: This does not work in many browsers (IE, Chrome). I propose that the links are changed like this: This can be done using this patch to App::ArchiveDevelCover: @@ -116,8 +116,8 @@ sub update_archive_html { my $prev_stats = $self->previous_stats; my $runtime = $self->runtime; my $date = $runtime->ymd('-').' '.$runtime->hms; - my $link = $runtime->iso8601."/coverage.html"; - my $diff = $runtime->iso8601."/diff.html"; + my $link = "./".$runtime->iso8601."/coverage.html"; + my $diff = "./".$runtime->iso8601."/diff.html"; my $new_stat = qq{n$date [1]diff [2]}; foreach my $val (@$last_row) { I attach an extended version of t/archive.t that tests the links in the index.shtml - file. Distribution: App-ArchiveDevelCover-1.001 Perl version: 5.14.2 OS: Linux gnu.jobsafari.dk 2.6.18-308.16.1.el5 #1 SMP Tue Oct 2 22:01:43 EDT 2012 x86_64 x86_64 x86_64 GNU/Linux Kind regards Henrik Hald Nørgaard, Programmør Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf.: +45 38 32 33 55, dir.: +45 38 32 33 81 www.jobindex.dk Links: ------ [1] http://mail.jobindex.dk/$link [2] http://mail.jobindex.dk/$diff
Download archive.t
text/x-perl 2.1k

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 213b
On Sat Nov 10 11:56:01 2012, hhn@jobindex.dk wrote: Show quoted text
> I propose that the links > are changed like this:
I've applied your patches. New version 1.002 is on it's way to CPAN now. Thanks a lot! Greetings, domm


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.