Skip Menu |
 

This queue is for tickets about the XML-Compile-WSS-Signature CPAN distribution.

Report information
The Basics
Id: 81065
Status: resolved
Priority: 0/
Queue: XML-Compile-WSS-Signature

People
Owner: Nobody in particular
Requestors: chernomyrdin [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.90
Fixed in: 1.08



Subject: unexpected file :-)
Please remove lib/XML/Compile/WSS/.Signature.pm.swp from XML-Compile-WSS-Signature-0.90.tar.gz
Subject: Re: [rt.cpan.org #81065] unexpected file :-)
Date: Fri, 9 Nov 2012 10:03:34 +0100
To: "http://chernomyrdin.ya.ru/ via RT" <bug-XML-Compile-WSS-Signature [...] rt.cpan.org>
From: Mark Overmeer <secretaris [...] nluug.nl>
Download (untitled) / with headers
text/plain 963b
* http://chernomyrdin.ya.ru/ via RT (bug-XML-Compile-WSS-Signature@rt.cpan.org) [121109 08:20]: Show quoted text
> Fri Nov 09 03:20:28 2012: Request 81065 was acted upon. > Transaction: Ticket created by http://chernomyrdin.ya.ru/ > Queue: XML-Compile-WSS-Signature > Subject: unexpected file :-) > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=81065 > > > Please remove lib/XML/Compile/WSS/.Signature.pm.swp from > XML-Compile-WSS-Signature-0.90.tar.gz
Oi, slipped through in the MANIFEST. Are use using this module? It is under active development, I do know of a few problems especially canonicalization. Patches welcome. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Subject: Re: [rt.cpan.org #81065] unexpected file :-)
Date: Fri, 9 Nov 2012 12:26:05 +0300
To: bug-XML-Compile-WSS-Signature [...] rt.cpan.org
From: Andrey Chernomyrdin <chernomyrdin [...] gmail.com>
Download (untitled) / with headers
text/plain 1.7k
Not using right now, but try make debian package from tarbal. For future using :-) Firest: I write about small problem with debianize XML-Compile* packages: You use Digest::SHA1, but in debian and ubuntu use Digest::SHA (newer and performace version). When I packaging I ,ake small patches for replace Digest::SHA1 into Digest::SHA. Second: in lib/XML/Compile/WSS/Signature.pm sub digester using Digest->new($algo), and $algo = SHA1, but for module Digest, better using SHA-1 for this argument will be try load Digest::SHA if exist, on fail load Digest::SHA1 On Fri, Nov 9, 2012 at 1:03 PM, Mark Overmeer via RT < bug-XML-Compile-WSS-Signature@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=81065 > > > * http://chernomyrdin.ya.ru/ via RT ( > bug-XML-Compile-WSS-Signature@rt.cpan.org) [121109 08:20]:
> > Fri Nov 09 03:20:28 2012: Request 81065 was acted upon. > > Transaction: Ticket created by http://chernomyrdin.ya.ru/ > > Queue: XML-Compile-WSS-Signature > > Subject: unexpected file :-) > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=81065 > > > > > Please remove lib/XML/Compile/WSS/.Signature.pm.swp from > > XML-Compile-WSS-Signature-0.90.tar.gz
> > Oi, slipped through in the MANIFEST. Are use using this module? > It is under active development, I do know of a few problems especially > canonicalization. Patches welcome. > -- > Regards, > MarkOv > > ------------------------------------------------------------------------ > Mark Overmeer MSc MARKOV Solutions > Mark@Overmeer.net solutions@overmeer.net > http://Mark.Overmeer.net http://solutions.overmeer.net > > >
p.s. sorry for my ugly english. -- With best, Andrey Chernomyrdin
Subject: Re: [rt.cpan.org #81065] unexpected file :-)
Date: Fri, 9 Nov 2012 10:47:57 +0100
To: "chernomyrdin [...] gmail.com via RT" <bug-XML-Compile-WSS-Signature [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
Download (untitled) / with headers
text/plain 1.8k
* chernomyrdin@gmail.com via RT (bug-XML-Compile-WSS-Signature@rt.cpan.org) [121109 09:26]: Show quoted text
> Queue: XML-Compile-WSS-Signature > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=81065 > > > Not using right now, but try make debian package from tarbal. For future > using :-)
Ok, please do not release the current release, start with the next. Show quoted text
> Firest: I write about small problem with debianize XML-Compile* packages: > You use Digest::SHA1, but in debian and ubuntu use Digest::SHA (newer and > performace version). > When I packaging I ,ake small patches for replace Digest::SHA1 into > Digest::SHA.
No, please. Do not give yourself the freedom to mess with the authors choice. Imagine: I try to fix all reported bugs imediately... when my released module has been modified, I may spend days investigation the bug introduced by someone else. I have encountered "smart" packagers before, I hate it. Please do send me bug-reports (very welcome, thanks in advance) but do *not* change my code. Show quoted text
> Second: in lib/XML/Compile/WSS/Signature.pm sub digester using > Digest->new($algo), and $algo = SHA1, but for module Digest, better using > SHA-1 for this argument will be try load Digest::SHA if exist, on fail load > Digest::SHA1
I can not help it when Digest is not smarter than that. Help that author to improve his logic. I will not change my code: my module is agnostic about the supported digest algorithm. There are many, I do not want to maintain a translation table just to make Digest to work a little more efficient (probably unmeasurable performance improvement) -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Subject: Re: [rt.cpan.org #81065] unexpected file :-)
Date: Thu, 15 Nov 2012 08:51:17 +0100
To: "chernomyrdin [...] gmail.com via RT" <bug-XML-Compile-WSS-Signature [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
Download (untitled) / with headers
text/plain 627b
* chernomyrdin@gmail.com via RT (bug-XML-Compile-WSS-Signature@rt.cpan.org) [121109 09:26]: Show quoted text
> Queue: XML-Compile-WSS-Signature > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=81065 > > > When I packaging I make small patches for replace Digest::SHA1 into > Digest::SHA.
Released as 1.06 -- MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Resolved last november


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.