Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-Tidy CPAN distribution.

Report information
The Basics
Id: 8051
Status: resolved
Priority: 0/
Queue: HTML-Tidy

People
Owner: Nobody in particular
Requestors: dom [...] idealx.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Date: Tue, 19 Oct 2004 15:49:11 +0200
From: Dominique Quatravaux <dom [...] idealx.com>
To: bug-html-tidy [...] rt.cpan.org, Andy Lester <andy [...] petdance.com>
Subject: [HTML::Tidy] t/segfault.t corrected
Download (untitled) / with headers
text/plain 792b
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, Attached is a patch to HTML::Tidy's Tidy.xs that fixes the t/segfault-form.t. Please apply against version 1.04. Although I do not (yet) fully understand the intended semantics of - ->clean(), I noticed that there was a code path where RETVAL would get no value before reaching the end of the function and I made it return undef in this case. Regards, - -- Dominique QUATRAVAUX Ingénieur senior 01 44 42 00 08 IDEALX -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFBdRtXMJAKAU3mjcsRAs4kAKC+pBX9pgFnCoNmBWSiQEH3WUtFvwCgnt50 uTpuR6mv6/2vfTyfI/Jwb7s= =iPrQ -----END PGP SIGNATURE-----
Download Tidy-segv.patch
text/x-diff 537b
diff -r -U3 HTML-Tidy-1.04/Tidy.xs HTML-Tidy-1.04.NEW/Tidy.xs --- HTML-Tidy-1.04/Tidy.xs Fri Apr 2 07:36:19 2004 +++ HTML-Tidy-1.04.NEW/Tidy.xs Tue Oct 19 15:33:09 2004 @@ -61,8 +61,11 @@ if ( rc >= 0 ) { char *str; str = (char *)output.bp; - if ( str ) + if ( str ) { RETVAL = newSVpvn( str, strlen(str) ); + } else { + RETVAL = &PL_sv_undef; + } tidyBufFree( &output ); } else { XSRETURN_UNDEF;
Thanks for the patch. Sorry it's taken 6 months to apply. It'll be in 1.05_02 tonight.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.