Skip Menu |
 

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 80479
Status: open
Priority: 0/
Queue: Net-Ping

People
Owner: SMPETERS [...] cpan.org
Requestors: VINSWORLD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.36
Fixed in: (no value)



Subject: IPv6 Support - with patch!
Download (untitled) / with headers
text/plain 826b
There is currently no IPv6 support in Net::Ping relying on IPv4 only routines like sockaddr_in and inet_ntoa/aton. I've created a patch to support IPv6. It's 95% complete. I'm having issues calculating the ICMPv6 checksum. As you may know, the ICMPv6 checksum is different than ICMPv4 in that ICMPv6 uses a pseudo-header (much like TCP/UDP) for checksum calculation. How to find the source address if the user does not call bind() before actually sending the packet? Other than that, IPv4 remains the default and all tests result in the same output for me as they did before the patch. IPv6 ping now also works, only not with ICMPv6 as transport (due to aforementioned checksum issue). I'd like some help getting that last ICMPv6 checksum part resolved and get this IPv6 support added to Net::Ping. cheers.
Subject: Ping.patch
Download Ping.patch
text/x-diff 25k

Message body is not shown because it is too large.

From: tlhackque [...] yahoo.com
Download (untitled) / with headers
text/plain 183b
Whether or not the suggested patch is the right approach, IPv6 support for this core module would be appreciated. IPv6 adoption is increasing, and this is a hole in Perl's support.
From: tlhackque [...] yahoo.com
Download (untitled) / with headers
text/plain 615b
With respect to the questions about the patch: A quick search turns up the source for ping6 at http://cvsweb.netbsd.org/bsdweb.cgi/src/sbin/ping6/ping6.c? rev=1.81&content-type=text/x-cvsweb-markup&only_with_tag=MAIN Checksum: The header checksum field is initialized to zero, but not computed - I assume (but haven't dug in) that sendmsg computes. Source address: When no explicit interface is bound, the source address is determined by indirectly consulting the routing tables - a UDP socket is connect() ed and getsockname() called. Look for the code under if (!(options & F_SRCADDR)) Hope this helps.
Download (untitled) / with headers
text/plain 586b
I will be looking at this patch soon. I have applied some other lower priority changes to Net::Ping for the 2.40 release that will make this change difficult to apply. In addition, I will be working on the new() for Net::Ping. With the addition of IPv6 support, there will be seven optional parameters to new, which is just silly and screams reworking. Most of the code, however, should be able to be applied as is. The 2.40 release should be out within the next month. This may be able to be included as well, or it will be in the next release after that so about two months out.
Subject: Re: [rt.cpan.org #80479] IPv6 Support - with patch!
Date: Thu, 14 Mar 2013 12:23:27 -0400
To: bug-Net-Ping [...] rt.cpan.org
From: Vince <vin [...] vinsworld.com>
Download (untitled) / with headers
text/plain 1.1k
Named arguments to new() may be a good idea. I tried to work within the original structure of the module for the IPv6 inclusion, but if you're looking to rework the structure, there are certainly better ways to include IPv6 support than what I coded in the patch. Let me know if there is anything I can do to help keeping in mind I'm not the most talented Perl hacker. cheers. On Thu, Mar 14, 2013 at 12:17 PM, Steve Peters via RT <bug-Net-Ping@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=80479 > > > I will be looking at this patch soon. I have applied some other lower > priority changes to Net::Ping for the 2.40 release that will make this > change difficult to apply. In addition, I will be working on the new() > for Net::Ping. With the addition of IPv6 support, there will be seven > optional parameters to new, which is just silly and screams reworking. > Most of the code, however, should be able to be applied as is. The 2.40 > release should be out within the next month. This may be able to be > included as well, or it will be in the next release after that so about > two months out.
From: tlhackque [...] yahoo.com
Download (untitled) / with headers
text/plain 801b
On Thu Mar 14 12:17:23 2013, SMPETERS wrote: Show quoted text
> I will be looking at this patch soon. I have applied some other lower > priority changes to Net::Ping for the 2.40 release that will make this > change difficult to apply. In addition, I will be working on the new() > for Net::Ping. With the addition of IPv6 support, there will be seven > optional parameters to new, which is just silly and screams reworking. > Most of the code, however, should be able to be applied as is. The 2.40 > release should be out within the next month. This may be able to be > included as well, or it will be in the next release after that so about > two months out.
Er, 'ping'? I know we're all volunteers/busy, but IPv6 continues to grow, and it has been almost a year since you guestimated a couple of months...
Subject: Re: [rt.cpan.org #80479] IPv6 Support - with patch!
Date: Mon, 3 Feb 2014 19:25:30 -0500
To: bug-Net-Ping [...] rt.cpan.org
From: Vince <vin [...] vinsworld.com>
Download (untitled) / with headers
text/plain 1.1k
You realize SMPETERS wrote the update you're referring to. I posted the original feature request for IPv6 with a proof of concept patch. I don't own or maintain the module. Cheers. On Feb 3, 2014 6:59 PM, "via RT" <bug-Net-Ping@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=80479 > > > On Thu Mar 14 12:17:23 2013, SMPETERS wrote:
> > I will be looking at this patch soon. I have applied some other lower > > priority changes to Net::Ping for the 2.40 release that will make this > > change difficult to apply. In addition, I will be working on the new() > > for Net::Ping. With the addition of IPv6 support, there will be seven > > optional parameters to new, which is just silly and screams reworking. > > Most of the code, however, should be able to be applied as is. The 2.40 > > release should be out within the next month. This may be able to be > > included as well, or it will be in the next release after that so about > > two months out.
> > Er, 'ping'? I know we're all volunteers/busy, but IPv6 continues to grow, > and it has been almost a year since you guestimated a couple of months... > > >
Subject: Re: [rt.cpan.org #80479] IPv6 Support - with patch!
Date: Mon, 3 Feb 2014 21:35:41 -0700
To: bug-Net-Ping [...] rt.cpan.org
From: Rob Brown <bbb [...] cpan.org>
Download (untitled) / with headers
text/plain 1.3k
I don't think the patch has been incorporated yet. On Mon, Feb 3, 2014 at 5:25 PM, vinsworldcom via RT < bug-Net-Ping@rt.cpan.org> wrote: Show quoted text
> Queue: Net-Ping > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=80479 > > > You realize SMPETERS wrote the update you're referring to. I posted the > original feature request for IPv6 with a proof of concept patch. I don't > own or maintain the module. > > Cheers. > On Feb 3, 2014 6:59 PM, "via RT" <bug-Net-Ping@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=80479 > > > > > On Thu Mar 14 12:17:23 2013, SMPETERS wrote:
> > > I will be looking at this patch soon. I have applied some other lower > > > priority changes to Net::Ping for the 2.40 release that will make this > > > change difficult to apply. In addition, I will be working on the new() > > > for Net::Ping. With the addition of IPv6 support, there will be seven > > > optional parameters to new, which is just silly and screams reworking. > > > Most of the code, however, should be able to be applied as is. The
> 2.40
> > > release should be out within the next month. This may be able to be > > > included as well, or it will be in the next release after that so about > > > two months out.
> > > > Er, 'ping'? I know we're all volunteers/busy, but IPv6 continues to
> grow,
> > and it has been almost a year since you guestimated a couple of months... > > > > > >
> >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.