Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 80225
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: alexm [...] cpan.org
dolmen [...] cpan.org
ether [...] cpan.org
KENTNL [...] cpan.org
wyant [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: [patches] Test failures due to Test::CPAN::Meta::YAML::Version interface change
Download (untitled) / with headers
text/plain 678b
When Test-CPAN-Meta-YAML was upgraded to version 0.21 (August 12 2012) there was an interface change in Test::CPAN::Meta::YAML::Version. The actual YAML data, formerly passed as key 'yaml', is now passed as key 'data'. The attached patches update Module::CPANTS::Kwalitee::MetaYAML to track this change, and Build.PL and Makefile.PL to require Test::CPAN::Meta::YAML::Version version 0.21. They have been tested successfully under Perls 5.14.3, 5.16.1, and 5.17.4. For what it's worth, tickets 79513 and 80208 appear to be the same problem. I started another ticket simply to get a title that said why the test failures occurred, and to specify that patch files were attached.
Subject: Module-CPANTS-Analyse-Makefile.diff
--- Makefile.old 2012-04-10 18:00:00.000000000 -0400 +++ Makefile.PL 2012-10-16 12:51:44.000000000 -0400 @@ -26,7 +26,7 @@ 'Readonly' => '0', 'Set::Scalar' => 0, 'Software::License' => '0.003', - 'Test::CPAN::Meta::YAML::Version' => '0', + 'Test::CPAN::Meta::YAML::Version' => '0.21', # Interface change 'Test::Deep' => 0, 'Test::More' => 0, 'Test::NoWarnings' => 0,
Subject: Module-CPANTS-Kwalitee-MetaYML.diff
--- lib/Module/CPANTS/Kwalitee/MetaYML.old 2012-04-10 18:00:00.000000000 -0400 +++ lib/Module/CPANTS/Kwalitee/MetaYML.pm 2012-10-16 12:41:01.000000000 -0400 @@ -137,7 +137,7 @@ my $yaml=$d->{meta_yml}; my %hash=( - yaml=>$yaml, + data=>$yaml, # Interface change in v0.21. Was 'yaml'. ); if (!$version) {
Subject: Module-CPANTS-Analyse-Build.diff
--- Build.old 2012-04-10 18:00:00.000000000 -0400 +++ Build.PL 2012-10-16 12:53:41.000000000 -0400 @@ -26,7 +26,7 @@ 'Text::CSV_XS' => '0.45', 'LWP::Simple' => 0, 'perl' => 5.006, - 'Test::CPAN::Meta::YAML::Version' => '0', + 'Test::CPAN::Meta::YAML::Version' => '0.21', # Interface change 'ExtUtils::Manifest' => 0, 'Set::Scalar' => 0, 'File::chdir' => 0,
Download (untitled) / with headers
text/plain 146b
Just to confirm that in version 0.86 t/10_analyse.t was failing and the patch supplied fixed it for me. Martin -- Martin J. Evans Wetherby, UK
Download (untitled) / with headers
text/plain 538b
Le 2012-10-16 19:10:52, WYANT a écrit : Show quoted text
> When Test-CPAN-Meta-YAML was upgraded to version 0.21 (August 12 2012) > there was an interface change in Test::CPAN::Meta::YAML::Version. The > actual YAML data, formerly passed as key 'yaml', is now passed as key > 'data'.
I made a Github pull request from Tom's patches. https://github.com/daxim/Module-CPANTS-Analyse/pull/4 Can someone merge it and release it? (This was done at the Quack and Hack 2012 Europe ; thanks to the sponsors) -- Olivier Mengué - http://perlresume.org/DOLMEN
Just confirming that the patches work as expected. Thanks a lot! Alex
fixed in 0.87


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.