Skip Menu |
 

This queue is for tickets about the PAR-Packer CPAN distribution.

Report information
The Basics
Id: 80062
Status: rejected
Priority: 0/
Queue: PAR-Packer

People
Owner: Nobody in particular
Requestors: shay [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.013
Fixed in: (no value)



Subject: Over-zealous disabling of --info (and no disabling of --icon)
Download (untitled) / with headers
text/plain 1.3k
I've recently updated a perl installation from PAR::Packer 1.008 to 1.013 and am surprised and disappointed to find that the -N option to pp no longer works for setting ProductVersion/FileVersion. It spits out a warning saying "--info is currently broken, disabling it...", and yet this used to work fine. With 1.008: D:\temp>pp -o hello.exe -N ProductVersion=1.2.3.4 hello.pl D:\temp>hello.exe Hello, world. (and ProductVersion is correctly set) With 1.013: D:\temp>pp -o hello.exe -N ProductVersion=1.2.3.4 hello.pl C:\perl\bin/pp: --info is currently broken, disabling it at C:/perl/site/lib/PAR/Packer.pm line 1177, <DATA> line 1. I see the BIG FAT WARNING in the ChangeLog file, but has this been done wrongly? I've personally never had any trouble setting ProductVersion/FileVersion fields, so it seems a great shame to disable all --info fields just because some don't get set; it was (and still is) setting the --icon file which corrupts the executable, and yet that option isn't disabled... I think --icon should be disabled since it always corrupts the executable, and --info should perhaps just emit a warning rather than disable the option, or at least only disable it when setting more than ProductVersion/FileVersion if other fields really don't work. Right now, I've simply lost functionality which used to work, and indeed still does if I delete the option-disabling code.
Download (untitled) / with headers
text/plain 654b
On 2012-10-08 11:12:30, SHAY wrote: Show quoted text
> I see the BIG FAT WARNING in the ChangeLog file, but has this been
done wrongly? No, it hasn't. Just because it works for you, doesn't mean it works for everybody. Show quoted text
> setting the --icon file which corrupts the executable, and yet that > option isn't disabled...
Please file a bug for this. Show quoted text
> Right now, I've simply lost functionality which used to work, and indeed > still does if I delete the option-disabling code.
Unless someone comes up with a fix, it will stay that way. I have zero interest in maintaining Windows-only features that are at best marginal to PAR::Packer's functionality. Cheers, Roderich


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.