Skip Menu |
 

This queue is for tickets about the HTTP-Server-Simple CPAN distribution.

Report information
The Basics
Id: 80041
Status: resolved
Priority: 0/
Queue: HTTP-Server-Simple

People
Owner: Nobody in particular
Requestors: polatel [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Tests should not bind to 0.0.0.0
Tests should not bind to 0.0.0.0 Patch attached.
Subject: HTTP-Server-Simple-0.41-localhost.patch
diff -ur HTTP-Server-Simple-0.41/t/01live.t HTTP-Server-Simple-0.41-localhost/t/01live.t --- HTTP-Server-Simple-0.41/t/01live.t 2009-08-12 19:13:55.000000000 +0300 +++ HTTP-Server-Simple-0.41-localhost/t/01live.t 2012-10-06 21:28:19.706591345 +0300 @@ -109,6 +109,7 @@ sub run_server_tests { my $class = shift; my $s = $class->new($PORT); + $s->host("localhost"); is($s->port(),$PORT,"Constructor set port correctly"); my $pid=$s->background(); diff -ur HTTP-Server-Simple-0.41/t/04cgi.t HTTP-Server-Simple-0.41-localhost/t/04cgi.t --- HTTP-Server-Simple-0.41/t/04cgi.t 2009-08-12 18:48:56.000000000 +0300 +++ HTTP-Server-Simple-0.41-localhost/t/04cgi.t 2012-10-06 21:28:51.966590653 +0300 @@ -32,6 +32,7 @@ { my $server=CGIServer->new($PORT); is($server->port(),$PORT,'Constructor set port correctly'); + $server->host("localhost"); sleep(3); # wait just a moment my $pid=$server->background;
Subject: Re: [rt.cpan.org #80041] Tests should not bind to 0.0.0.0
Date: Tue, 09 Oct 2012 10:09:21 -0700
To: bug-HTTP-Server-Simple [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Download (untitled) / with headers
text/plain 322b
The patch doesn't apply cleanly to the tip of master in git (also currently release 0.45_02). When I hand apply the patch, tests fail for me for what looks like differences between IPv4 and IPv6. Can you re-roll the patch to apply to the tip of master and pass tests? http://github.com/bestpractical/http-server-simple
Download (untitled) / with headers
text/plain 357b
On Sat Oct 06 14:45:03 2012, https://www.google.com/accounts/o8/id?id=AItOawnmnQbVjGMDy8P7v8JSTQmK4tx0pS2tztA wrote: Show quoted text
> Tests should not bind to 0.0.0.0 > Patch attached.
Looks like during my work for 0.50 I cleaned this up (including the ipv6 failures related to blindly using 'localhost' when many systems name their IPv6 loopback something else). -kevin


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.