Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Starman CPAN distribution.

Report information
The Basics
Id: 79865
Status: open
Priority: 0/
Queue: Starman

People
Owner: Nobody in particular
Requestors: geir [...] aalberg.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.3002
Fixed in: (no value)



Subject: Hangs during make test
Download (untitled) / with headers
text/plain 1.1k
On a fresh install of Ubuntu, make test hangs when running findbin.t: t/findbin.t .............. 2012/09/26-14:55:06 Starman::Server (type Net::Server::PreFork) starting! pid(4613) Resolved [*]:50546 to [::]:50546, IPv6 Not including resolved host [0.0.0.0] IPv4 because it will be handled by [::] IPv6 Binding to TCP port 50546 on host :: with IPv6 Setting gid to "0 0 0" t/findbin.t .............. 1/? I have verified that the worker process is running and returns data: root@dev-vm244:~/.cpanm/work/1348654272.3674/Starman-0.3002# telnet localhost 50304 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. GET / HTTP/1.1 Host: localhost HTTP/1.1 200 OK Content-Type: text/plain Transfer-Encoding: chunked Date: Wed, 26 Sep 2012 10:46:29 GMT Connection: keep-alive 32 /root/.cpanm/work/1348654272.3674/Starman-0.3002/t 0 Connection closed by foreign host. (Note different port # due to being an earlier run.) Test fails consistently on 3 different Ubuntu servers, running both Lucid and Precise (perl v5.10.1 and v5.14.2 resp). If I try commenting out findbin.t, a similar problem occurs with rand.t. No difference if using cpan or cpanm.
I'm seeing the same problem. Again on Ubuntu but using a perlbrewed 5.16.1.
Subject: Re: [rt.cpan.org #79865] Hangs during make test
Date: Thu, 27 Sep 2012 08:35:05 +0900
To: bug-Starman [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Download (untitled) / with headers
text/plain 136b
Not reproducible here. Just to investigate the issue, can you see if the test fail with Starman 0.3001 as well? -- Tatsuhiko Miyagawa
RT-Send-CC: miyagawa [...] gmail.com
Download (untitled) / with headers
text/plain 1.5k
On Wed Sep 26 16:35:36 2012, miyagawa@gmail.com wrote: Show quoted text
> Not reproducible here. Just to investigate the issue, can you see if > the test fail with Starman 0.3001 as well?
I can reproduce on my ubuntu box. To reiterate from irc: - 0.3001 tests pass fine - removing the changes from t/findbin.t and t/rand.t eliminates the hang Changing t/findbin.t thusly passes tests again (I tested with a path with a space in it): --- Starman-0.3002/t/findbin.t 2012-09-24 23:25:39.000000000 -0700 +++ Starman-0.3002 fixed/t/findbin.t 2012-09-26 17:20:17.770018607 -0700 @@ -1,12 +1,12 @@ use Test::TCP; use LWP::UserAgent; -use FindBin; use Test::More; +use Path::Class; my $s = Test::TCP->new( code => sub { my $port = shift; - exec "$^X bin/starman --port $port --max-requests=1 --workers=1 '$FindBin::Bin/findbin.psgi'"; + exec($^X, file(qw(bin starman)), '--port', $port, '--max-requests=1', '--workers=1', file(qw(t findbin.psgi))->absolute); }, ); @@ -14,7 +14,7 @@ for (1..2) { my $res = $ua->get("http://localhost:" . $s->port); - is $res->content, $FindBin::Bin; + is $res->content, dir('t')->absolute; } Passing args as a list to exec() eliminates the involvement of the shell, so any spaces in the filename should be a non-issue. This will also bring back win32 compat (not sure if you care about that, or if it's already assumed to not be needed by other low-level things you do).
Subject: Re: [rt.cpan.org #79865] Hangs during make test
Date: Thu, 27 Sep 2012 09:47:30 +0900
To: bug-Starman [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Download (untitled) / with headers
text/plain 1.7k
Fixed in 0.3003. -- Tatsuhiko Miyagawa On Sep 27, 2012, at 9:24 AM, Karen Etheridge via RT wrote: Show quoted text
> Queue: Starman > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79865 > > > On Wed Sep 26 16:35:36 2012, miyagawa@gmail.com wrote:
>> Not reproducible here. Just to investigate the issue, can you see if >> the test fail with Starman 0.3001 as well?
> > I can reproduce on my ubuntu box. > To reiterate from irc: > > - 0.3001 tests pass fine > - removing the changes from t/findbin.t and t/rand.t eliminates the hang > > Changing t/findbin.t thusly passes tests again (I tested with a path > with a space in it): > > --- Starman-0.3002/t/findbin.t 2012-09-24 23:25:39.000000000 -0700 > +++ Starman-0.3002 fixed/t/findbin.t 2012-09-26 > 17:20:17.770018607 -0700 > @@ -1,12 +1,12 @@ > use Test::TCP; > use LWP::UserAgent; > -use FindBin; > use Test::More; > +use Path::Class; > > my $s = Test::TCP->new( > code => sub { > my $port = shift; > - exec "$^X bin/starman --port $port --max-requests=1 > --workers=1 '$FindBin::Bin/findbin.psgi'"; > + exec($^X, file(qw(bin starman)), '--port', $port, > '--max-requests=1', '--workers=1', file(qw(t findbin.psgi))->absolute); > }, > ); > > @@ -14,7 +14,7 @@ > > for (1..2) { > my $res = $ua->get("http://localhost:" . $s->port); > - is $res->content, $FindBin::Bin; > + is $res->content, dir('t')->absolute; > } > > Passing args as a list to exec() eliminates the involvement of the > shell, so any spaces in the filename should be a non-issue. > > This will also bring back win32 compat (not sure if you care about that, > or if it's already assumed to not be needed by other low-level things > you do). > >
Subject: Re: [rt.cpan.org #79865] Hangs during make test
Date: Thu, 27 Sep 2012 10:39:31 +0200
To: bug-Starman [...] rt.cpan.org
From: Geir Aalberg <geir [...] aalberg.com>
Download (untitled) / with headers
text/plain 2.2k
On 09/27/2012 02:47 AM, miyagawa@gmail.com via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=79865 > > > Fixed in 0.3003.
Thanks, the now tests pass fine under perl 5.14.2. However under 5.10.1 I get some warnings: t/rand.t ................. 2012/09/27-10:21:51 Starman::Server (type Net::Server::PreFork) starting! pid(25875) Binding to TCP port 50090 on host * Setting gid to "0 0 0" t/rand.t ................. 1/? 2012/09/27-10:21:51 Server closing! 2012/09/27-10:21:51 Starman::Server (type Net::Server::PreFork) starting! pid(25879) Binding to TCP port 50842 on host * Setting gid to "0 0 0" 2012/09/27-10:21:51 Server closing! Accept failed with 29 tries left: Invalid argument Accept failed with 28 tries left: Invalid argument Accept failed with 27 tries left: Invalid argument Accept failed with 26 tries left: Invalid argument Accept failed with 25 tries left: Invalid argument Accept failed with 24 tries left: Invalid argument Accept failed with 23 tries left: Invalid argument Accept failed with 22 tries left: Invalid argument Accept failed with 21 tries left: Invalid argument Accept failed with 20 tries left: Invalid argument Accept failed with 19 tries left: Invalid argument Accept failed with 18 tries left: Invalid argument Accept failed with 17 tries left: Invalid argument Accept failed with 16 tries left: Invalid argument Accept failed with 15 tries left: Invalid argument Accept failed with 14 tries left: Invalid argument Accept failed with 13 tries left: Invalid argument Accept failed with 12 tries left: Invalid argument Accept failed with 11 tries left: Invalid argument Accept failed with 10 tries left: Invalid argument Accept failed with 9 tries left: Invalid argument Accept failed with 8 tries left: Invalid argument Accept failed with 7 tries left: Invalid argument Accept failed with 6 tries left: Invalid argument Accept failed with 5 tries left: Invalid argument Accept failed with 4 tries left: Invalid argument Accept failed with 3 tries left: Invalid argument Accept failed with 2 tries left: Invalid argument Accept failed with 1 tries left: Invalid argument Accept failed with 0 tries left: Invalid argument Ran out of accept retries! t/rand.t ................. ok However I'm not gonna run Starman under 5.10 anyway, so problem solved for me. Thanks again!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.