Skip Menu |
 

This queue is for tickets about the Parse-CPAN-Packages CPAN distribution.

Report information
The Basics
Id: 79777
Status: resolved
Priority: 0/
Queue: Parse-CPAN-Packages

People
Owner: Nobody in particular
Requestors: strobert-bitcard [...] strobe.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in:
  • 2.34
  • 2.35
  • 2.36
  • 2.37
Fixed in: (no value)



Subject: Can you please change the usage of Test::IsDistDir to be optional?
Download (untitled) / with headers
text/plain 540b
Greetings, I am one of the co-maintainers of this perl package in the Fedora project (the the Fedora EPEL project as well) and was checking to see if an update was available. I saw 2.37 was out and as Fedora is on 2.33 figured I would try the update. It doesn't build however as Parse-CPAN-Packages now requires Test::IsDistDir. Could you look at making that module usage optional. here is a link I found on some approaches. basically include it in an eval in a BEGIN block. http://www.codingforums.com/archive/index.php/t-123477.html
Download (untitled) / with headers
text/plain 284b
Two notes: 1. It's Test::InDistDir, not "Is". :) 2. Can't you simply make a package for that module? It's entirely pureperl and straight-forward. I'd prefer not to introduce unncessary complexity to the code for something that could be resolved with extra value for everyone else.
Subject: Can you please change the usage of Test::InDistDir to be optional?
From: strobert-bitcard [...] strobe.net
Download (untitled) / with headers
text/plain 958b
On Fri Sep 21 06:29:40 2012, MITHALDU wrote: Show quoted text
> Two notes: > > 1. It's Test::InDistDir, not "Is". :)
whoops. what I get from typing it from memory :) Show quoted text
> 2. Can't you simply make a package for that module? It's entirely > pureperl and straight-forward. I'd prefer not to introduce unncessary > complexity to the code for something that could be resolved with extra > value for everyone else.
We probably could make a package for it. I thought about that. I wasn't sure how general purpose the Test::InDistDir was. it seemed like something mainly for desktops and not all folks (like on servers) who have/want installed. Although it is just needed if you are building a package or running tests manually. I checked the CPAN deps and it doesn't look like it is all that used, or are you thinking if we get it packaged it will hopefully get some more use since it sounds like it makes running tests under desktops IDEs easier? I'd be good with that.
Download (untitled) / with headers
text/plain 2.1k
On Fri Sep 21 22:41:37 2012, strobert wrote: Show quoted text
> > 2. Can't you simply make a package for that module? It's entirely > > pureperl and straight-forward. I'd prefer not to introduce > > unncessary complexity to the code for something that could be > > resolved with extra value for everyone else.
> > We probably could make a package for it. I thought about that. I > wasn't sure how general purpose the Test::InDistDir was. it seemed > like something mainly for desktops and not all folks (like on > servers) who have/want installed. > > Although it is just needed if you are building a package or running > tests manually. > > I checked the CPAN deps and it doesn't look like it is all that used, > or are you thinking if we get it packaged it will hopefully get some > more use since it sounds like it makes running tests under desktops > IDEs easier? > > I'd be good with that.
Sorry for taking a while to get back to you. I got sidetracked by many things. The purpose of Test::InDistDir is to allow users of any code editor that makes it possible to syntax-check files while editing, or to run files straight from the edit window, to do so without having to specifically configure the running environment for the file in their editor. This includes anything from Komodo over Emacs to vi. Due to the nature of Perl i could load it optionally from where it is, but the code required to doing so is almost as complicated as what the module does. (It really does not do a lot, it simply goes up a dir if it thinks it's being run in the test dir.) So, as i said, i do not wish to make it optional because that would require an undue amount of complexity; removing it makes my job unnecessarily harder; and if you make a package for it it can be useful for others on your platform too. It is not widely used, so that is speculative, but it is a thing. And lastly, on a personal note: The things Fedora does with the Perl core distribution have caused me plenty grief in the past, so i have to admit my willingness to make Fedora's life easier to my further detriment is exceptionally low, especially when the alternative solution carries almost zero cost.
From: strobert-bitcard [...] strobe.net
Download (untitled) / with headers
text/plain 2.8k
On Mon Dec 03 07:29:51 2012, MITHALDU wrote: Show quoted text
> On Fri Sep 21 22:41:37 2012, strobert wrote:
> > We probably could make a package for it. I thought about that. I > > wasn't sure how general purpose the Test::InDistDir was. it seemed > > like something mainly for desktops and not all folks (like on > > servers) who have/want installed. > > > > Although it is just needed if you are building a package or running > > tests manually. > > > > I checked the CPAN deps and it doesn't look like it is all that used, > > or are you thinking if we get it packaged it will hopefully get some > > more use since it sounds like it makes running tests under desktops > > IDEs easier? > > > > I'd be good with that.
> > Sorry for taking a while to get back to you. I got sidetracked by many > things. The purpose of Test::InDistDir is to allow users of any code > editor that makes it possible to syntax-check files while editing, or > to run files straight from the edit window, to do so without having to > specifically configure the running environment for the file in their > editor.
no problem. I had figured you were okay with the plan I'd outlined. I have been busy with other things including my day job, so hadn't gotten a chance to work on getting the new package built yet. Show quoted text
> This includes anything from Komodo over Emacs to vi.
any pointers on how to do it from within vi? I haven't dived yet too much into having vi integrate with compilers and such. Show quoted text
> Due to the nature of Perl i could load it optionally from where it is, > but the code required to doing so is almost as complicated as what the > module does. (It really does not do a lot, it simply goes up a dir if > it thinks it's being run in the test dir.) > > So, as i said, i do not wish to make it optional because that would > require an undue amount of complexity; removing it makes my job > unnecessarily harder; and if you make a package for it it can be useful > for others on your platform too. It is not widely used, so that is > speculative, but it is a thing.
which is what I had concluded that if we make a package it will hopefully promote the use and provide some value to more folks. and since it is a build,dev side dep it won't cause added reqs for folks that are using the packages and not developing them. Show quoted text
> And lastly, on a personal note: The things Fedora does with the Perl > core distribution have caused me plenty grief in the past, so i have to > admit my willingness to make Fedora's life easier to my further > detriment is exceptionally low, especially when the alternative > solution carries almost zero cost.
Sorry to hear about your past experiences. I'm new as a fedora packager. have mainly just been a user of RH-style linux for years building packages (including perl ones) for personal and work use. figured it would be good to get the fixes and work I have done contributed back to the community at large.
Download (untitled) / with headers
text/plain 1.1k
Thanks for the quick answer and for being understanding. :) Show quoted text
> any pointers on how to do it from within vi?
I don't use vi myself, but the most easy method is to define a shortcut to run `perl -c` on the file like so. http://lukesthoughtdump.blogspot.de/2009/06/checking-perl-syntax-within- vim.html Show quoted text
> if we make a package it will hopefully promote the use
Since that means more people doing realtime checking, i'm all for that. :) Show quoted text
> since it is a build,dev side dep it won't cause added > reqs for folks that are using the packages
That is a very good thing. Show quoted text
> figured it would be good to get the fixes and work I > have done contributed back to the community at large.
Totally, and i really appreciate it. My comment wasn't reflective on your work anyhow and only at some of the decisions made by fedora's upstream and carried on by fedora itself. (Try figuring out which perl core modules are missing in your perl package. ;) ) With that i'll mark this ticket as resolved for now. Answering it will reopen it, which i don't mind if you have further comments relevant to this. If you have further comments that aren't necessary for this ticket, you can also send them straight to my email address. :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.