This queue is for tickets about the Locale-SubCountry CPAN distribution.

Report information
The Basics
Id:
79734
Status:
resolved
Priority:
Low/Low

People
Owner:
kimryan [...] cpan.org
Requestors:
ivan-pause [...] 420.am
Cc:
AdminCc:

BugTracker
Severity:
Important
Broken in:
  • 1.51
  • 1.55
  • 1.56
Fixed in:
(no value)



Subject: Version checks fail ("our $VERSION" moved before "package Locale::SubCountry")
$ perl -e 'use Locale::SubCountry 54' Locale::SubCountry does not define $Locale::SubCountry::VERSION--version check failed at -e line 1. Sometime after version 1.50, "our $VERSION = 1.xx" was moved to the top of the code, above any "package" declaration. It is therefore not declaring $Locale::SubCountry::VERSION, and previously-working version checks like "use Locale::SubCountry 1.42" now throw a fatal error. The patch below adds a "package Locale::SubCountry" to the beginning of the code. This seems like typical / best practice for modules, to avoid any symbol exports from the intial "use" statements from polluting the main:: namespace. --- SubCountry.pm.ORIG 2012-09-18 13:02:15.702774878 -0700 +++ SubCountry.pm 2012-09-18 13:30:04.351443803 -0700 @@ -314,6 +314,8 @@ #------------------------------------------------------------------------------- +package Locale::SubCountry; + use strict; use warnings; use locale;
I just wanted to bump this issue. I'd really like to see this fixed as well.
Fixed in 1.57. Apologies for the delay.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.