Skip Menu |
 

This queue is for tickets about the Socket CPAN distribution.

Report information
The Basics
Id: 79071
Status: resolved
Priority: 0/
Queue: Socket

People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.005
Fixed in: 2.006



Subject: [PATCH] Bad skip count in t/sockaddr.t
The skip counts in the sockaddr_in6 block should be 9 and not 8. Patch attached.
Subject: socket.patch
Download socket.patch
text/x-diff 697b
--- Socket-2.005/t/sockaddr.t-orig 2012-08-18 08:24:35.605125000 -0400 +++ Socket-2.005/t/sockaddr.t 2012-08-18 08:29:42.631625000 -0400 @@ -85,8 +85,8 @@ # pack_sockaddr_in6, unpack_sockaddr_in6 # sockaddr_in6 SKIP: { - skip "No AF_INET6", 8 unless my $AF_INET6 = eval { Socket::AF_INET6() }; - skip "Cannot pack_sockaddr_in6()", 8 unless my $sin6 = eval { Socket::pack_sockaddr_in6(0x1234, "0123456789abcdef", 0, 89) }; + skip "No AF_INET6", 9 unless my $AF_INET6 = eval { Socket::AF_INET6() }; + skip "Cannot pack_sockaddr_in6()", 9 unless my $sin6 = eval { Socket::pack_sockaddr_in6(0x1234, "0123456789abcdef", 0, 89) }; ok(defined $sin6, 'pack_sockaddr_in6 defined');
Download (untitled) / with headers
text/plain 266b
On Sat Aug 18 08:32:21 2012, JDHEDDEN wrote: Show quoted text
> The skip counts in the sockaddr_in6 block should be 9 and not 8. Patch > attached.
Oops, absolutely right. I just added a new test in 2.005, and forgot to update that count. Will be in next release. -- Paul Evans
Fixed in 2.006. -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.