Skip Menu |
 

This queue is for tickets about the Tickit CPAN distribution.

Report information
The Basics
Id: 78919
Status: resolved
Priority: 0/
Queue: Tickit

People
Owner: Nobody in particular
Requestors: TEAM [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.19
Fixed in: 0.20

Attachments


Subject: Tickit::Widget::Frame->style($style) should be ->set_style($style) in docs
Download (untitled) / with headers
text/plain 376b
Looks like there's a minor typo in the Tickit::Widget::Frame documentation - the ->set_style method is documented as ->style, which leads to some minor confusion when trying to change it dynamically after construction =) I added a die when using ->style as a mutator so I could track any stray cases in my code, not sure if that part's worth keeping though. cheers, Tom
Subject: tickit-frame-docpatch.diff
diff -uNPr Tickit-0.19-original/lib/Tickit/Widget/Frame.pm Tickit-0.19-S2yM7S/lib/Tickit/Widget/Frame.pm --- Tickit-0.19-original/lib/Tickit/Widget/Frame.pm 2012-07-19 00:16:27.000000000 +0100 +++ Tickit-0.19-S2yM7S/lib/Tickit/Widget/Frame.pm 2012-08-12 11:11:06.191968520 +0100 @@ -145,10 +145,11 @@ sub style { my $self = shift; + die 'This is an accessor only, perhaps you meant ->set_style?' if @_; return $self->{style}; } -=head2 $frame->style( $style ) +=head2 $frame->set_style( $style ) Accessor for the C<style> property, which controls the way the actual frame is drawn around the inner widget. Must be one of the following names:
Download (untitled) / with headers
text/plain 334b
On Sun Aug 12 06:13:57 2012, TEAM wrote: Show quoted text
> Looks like there's a minor typo in the Tickit::Widget::Frame > documentation - the ->set_style method is documented as ->style, which > leads to some minor confusion when trying to change it dynamically after > construction =)
Oops. Now fixed in source. Will be in 0.20. -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.