Skip Menu |
 

This queue is for tickets about the BZ-Client CPAN distribution.

Report information
The Basics
Id: 78467
Status: resolved
Priority: 0/
Queue: BZ-Client

People
Owner: Nobody in particular
Requestors: bitcard [...] dm.cobite.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.04
Fixed in: (no value)

Attachments


Subject: iso8601 date parsing error with recent bugzilla
Download (untitled) / with headers
text/plain 569b
in version 1.04, BZ-Client implemented conversion of on-the-wire dates from XML into data objects using DateTime::Format::ISO8601. However, just around the same time, the bugzilla team changed the on-the-wire format of the dates to a non-conforming date format (due to some broken spec somewhere else). To work around this, BZ-Client needs to handle this newer broken date format, as well as the older standards compliant format. Patch is attached. See also the bugzilla bug referencing the change in bugizilla: https://bugzilla.mozilla.org/show_bug.cgi?id=550618
Subject: BZ-Client-noncompliant-iso8601date.patch
--- BZ/Client/XMLRPC/Value.pm~ 2011-08-22 09:52:47.000000000 -0400 +++ BZ/Client/XMLRPC/Value.pm 2012-07-18 15:37:43.715726217 -0400 @@ -71,7 +71,11 @@ $self->{'level1_content'} = undef; $self->{'level1_elem'} = undef; if ("dateTime.iso8601" eq $name) { - $self->{'result'} = DateTime::Format::ISO8601->parse_datetime( $self->{'result'} ); + my $val = $self->{'result'}; + if ($val =~ /(\d\d\d\d)(\d\d)(\d\d)(T\d\d:\d\d:\d\d)/) { + $val = "$1-$2-$3$4"; + } + $self->{'result'} = DateTime::Format::ISO8601->parse_datetime( $val ); } } }
Download (untitled) / with headers
text/plain 729b
On Thu Jul 19 14:41:19 2012, dmansfield wrote: Show quoted text
> in version 1.04, BZ-Client implemented conversion of on-the-wire dates > from XML into data objects using DateTime::Format::ISO8601. However, > just around the same time, the bugzilla team changed the on-the-wire > format of the dates to a non-conforming date format (due to some broken > spec somewhere else). To work around this, BZ-Client needs to handle > this newer broken date format, as well as the older standards compliant > format. > > Patch is attached. > > See also the bugzilla bug referencing the change in bugizilla: > > https://bugzilla.mozilla.org/show_bug.cgi?id=550618
I have added this patch to my github version -> https://github.com/djzort/BZ-Client
Download (untitled) / with headers
text/plain 850b
This was applied some time ago On Wed Dec 11 22:10:56 2013, djzort wrote: Show quoted text
> On Thu Jul 19 14:41:19 2012, dmansfield wrote:
> > in version 1.04, BZ-Client implemented conversion of on-the-wire > > dates > > from XML into data objects using DateTime::Format::ISO8601. However, > > just around the same time, the bugzilla team changed the on-the-wire > > format of the dates to a non-conforming date format (due to some > > broken > > spec somewhere else). To work around this, BZ-Client needs to handle > > this newer broken date format, as well as the older standards > > compliant > > format. > > > > Patch is attached. > > > > See also the bugzilla bug referencing the change in bugizilla: > > > > https://bugzilla.mozilla.org/show_bug.cgi?id=550618
> > > I have added this patch to my github version -> > https://github.com/djzort/BZ-Client


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.