Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-Tidy CPAN distribution.

Report information
The Basics
Id: 7836
Status: resolved
Priority: 0/
Queue: HTML-Tidy

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.05_01
Fixed in: (no value)



Subject: fail t\extra-quote.t : not ok 4 - Matching warnings
Download (untitled) / with headers
text/plain 138b
You need to add s/[\r\n]+\z// for @strings; to get rid of trailing \r's (maybe on some platforms there are \n's also) patch included
Download the.patch
text/x-diff 2k
diff -ub t/extra-quote.t new-t/extra-quote.t --- t/extra-quote.t 2004-02-25 18:48:36.000000000 -0800 +++ new-t/extra-quote.t 2004-09-30 15:48:46.281250000 -0700 @@ -28,6 +28,7 @@ is( scalar @messages, 3 ); my @strings = map { $_->as_string } @messages; +s/[\r\n]+\z// for @strings; is_deeply( \@strings, \@expected, "Matching warnings" ); __DATA__ diff -ub t/ignore-text.t new-t/ignore-text.t --- t/ignore-text.t 2004-02-25 18:48:48.000000000 -0800 +++ new-t/ignore-text.t 2004-09-30 15:49:27.078125000 -0700 @@ -25,6 +25,7 @@ $tidy->parse( "DATA", $html ); my @returned = map { $_->as_string } $tidy->messages; + s/[\r\n]+\z// for @returned; is_deeply( \@returned, \@expected_messages, "Matching warnings" ); } diff -ub t/ignore.t new-t/ignore.t --- t/ignore.t 2004-02-25 18:48:45.000000000 -0800 +++ new-t/ignore.t 2004-09-30 15:49:20.906250000 -0700 @@ -30,6 +30,7 @@ $tidy->parse( "-", $html ); my @returned = map { $_->as_string } $tidy->messages; + s/[\r\n]+\z// for @returned; is_deeply( \@returned, \@expected_warnings, "Matching warnings" ); } @@ -41,6 +42,7 @@ $tidy->parse( "-", $html ); my @returned = map { $_->as_string } $tidy->messages; + s/[\r\n]+\z// for @returned; is_deeply( \@returned, \@expected_errors, "Matching errors" ); } diff -ub t/levels.t new-t/levels.t --- t/levels.t 2004-02-25 18:48:54.000000000 -0800 +++ new-t/levels.t 2004-09-30 15:49:43.812500000 -0700 @@ -20,6 +20,7 @@ shift @expected; # First one's blank my @messages = map { $_->as_string } $tidy->messages; +s/[\r\n]+\z// for @messages; is_deeply( \@messages, \@expected, "Matching messages" ); __DATA__ diff -ub t/too-many-titles.t new-t/too-many-titles.t --- t/too-many-titles.t 2004-02-25 18:49:05.000000000 -0800 +++ new-t/too-many-titles.t 2004-09-30 15:49:51.390625000 -0700 @@ -17,6 +17,7 @@ $tidy->parse( "-", $html ); my @returned = map { $_->as_string } $tidy->messages; +s/[\r\n]+\z// for @returned; is_deeply( \@returned, \@expected, "Matching warnings" ); __DATA__
Going into 1.05_02


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.