Skip Menu |
 

This queue is for tickets about the MIME-tools CPAN distribution.

Report information
The Basics
Id: 77582
Status: resolved
Priority: 0/
Queue: MIME-tools

People
Owner: dfs+pause [...] roaringpenguin.com
Requestors: chisel [...] chizography.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 5.502
Fixed in: (no value)



Subject: This distribution does not 'use strict;' in all of its modules.
Download (untitled) / with headers
text/plain 3.1k
I think this started happening after an earlier stage in our build process installed one of the Kwalitee modules: /usr/bin/make -j 3 -j 3 -- OK Running make test PERL_DL_NONLAZY=1 /disk/jkns/workspace/perl-nap-CPAN/build/tmp/perl-nap-5.14.2- 2012.08.02.73.g190b9e0-build/opt/xt/xt-perl/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t # Failed test 'use_strict' # at /disk/jkns/workspace/perl-nap-CPAN/build/tmp/perl-nap-5.14.2- 2012.08.02.73.g190b9e0-build/opt/xt/xt-perl/lib/site_perl/5.14.2/Test/Kwalitee.pm line 101. # Add 'use strict' to all modules.This distribution does not 'use strict;' in all of its modules. # Looks like you failed 1 test of 13. t/02-kwalitee.t ................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests t/02-pod-coverage.t ............... skipped: Test::Pod::Coverage disabled. TEST_POD_COVERAGE=1 if you want it. t/02-pod.t ........................ ok t/99-prepare.t .................... ok t/attachment-filename-encoding.t .. ok t/Body.t .......................... ok t/BodyPrint.t ..................... ok # Using gzip: 1 t/Decoder.t ....................... ok t/EmptyPart.t ..................... ok t/Entity.t ........................ ok Wide character in print at /disk/jkns/workspace/perl-nap-CPAN/build/tmp/perl-nap- 5.14.2-2012.08.02.73.g190b9e0-build/opt/xt/xt-perl/lib/5.14.2/Test/Builder.pm line 1759. Wide character in print at /disk/jkns/workspace/perl-nap-CPAN/build/tmp/perl-nap- 5.14.2-2012.08.02.73.g190b9e0-build/opt/xt/xt-perl/lib/5.14.2/Test/Builder.pm line 1759. t/Filer.t ......................... ok t/Gauntlet.t ...................... ok t/Head.t .......................... ok t/Misc.t .......................... ok t/ParamVal.t ...................... ok t/Parser.t ........................ ok t/ParserEncoded.t ................. ok t/ParserPreamble.t ................ ok t/Ref.t ........................... ok t/Smtpsend.t ...................... ok t/ticket-11901.t .................. ok t/ticket-22684.t .................. ok t/ticket-37139.t .................. ok t/ticket-41632.t .................. ok t/ticket-43439.t .................. ok t/ticket-52924.t .................. ok t/ticket-60931.t .................. ok t/ticket-65681.t .................. ok t/ticket-66025.t .................. ok t/WordDecoder.t ................... ok t/WordEncoder.t ................... ok t/Words.t ......................... ok Test Summary Report ------------------- t/02-kwalitee.t (Wstat: 256 Tests: 13 Failed: 1) Failed test: 11 Non-zero exit status: 1 Files=32, Tests=423, 10 wallclock secs ( 0.16 usr 0.04 sys + 7.28 cusr 0.40 csys = 7.88 CPU) Result: FAIL Failed 1/32 test programs. 1/423 subtests failed. make: *** [test_dynamic] Error 255 NETAPORTER/MIME-tools-5.502.tar.gz /usr/bin/make test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports NETAPORTER/MIME-tools-5.502.tar.gz Running make install make test had returned bad status, won't install without force Stopping: 'install' failed for 'MIME::Parser'. *** MIME::Parser installation failed. # MIME::Parser failed to install: SADFACE
Subject: Re: [rt.cpan.org #77582] This distribution does not 'use strict;' in all of its modules.
Date: Fri, 1 Jun 2012 16:18:49 -0400
To: bug-MIME-tools [...] rt.cpan.org
From: "David F. Skoll" <dfs [...] roaringpenguin.com>
Download (untitled) / with headers
text/plain 1.9k
Hi, Show quoted text
> # Add 'use strict' to all modules.
Thanks. I've fixed it in git and the fix will be in the next release. The git diff is below. Regards, David. ============================================================================= commit e5f212e9c7e520a96162bed387bb3fb6bb428527 Author: David F. Skoll <dfs@roaringpenguin.com> Date: Fri Jun 1 16:16:22 2012 -0400 Add "use strict" everywhere. diff --git a/lib/MIME/Decoder/Base64.pm b/lib/MIME/Decoder/Base64.pm index c1a892c..d516972 100644 --- a/lib/MIME/Decoder/Base64.pm +++ b/lib/MIME/Decoder/Base64.pm @@ -1,4 +1,6 @@ package MIME::Decoder::Base64; +use strict; +use warnings; =head1 NAME diff --git a/lib/MIME/Decoder/BinHex.pm b/lib/MIME/Decoder/BinHex.pm index 1211fbb..785bf0d 100644 --- a/lib/MIME/Decoder/BinHex.pm +++ b/lib/MIME/Decoder/BinHex.pm @@ -1,4 +1,6 @@ package MIME::Decoder::BinHex; +use strict; +use warnings; =head1 NAME diff --git a/lib/MIME/Decoder/Binary.pm b/lib/MIME/Decoder/Binary.pm index 85243b0..12caa98 100644 --- a/lib/MIME/Decoder/Binary.pm +++ b/lib/MIME/Decoder/Binary.pm @@ -1,4 +1,6 @@ package MIME::Decoder::Binary; +use strict; +use warnings; =head1 NAME diff --git a/lib/MIME/Decoder/NBit.pm b/lib/MIME/Decoder/NBit.pm index fd52cc5..7995cfd 100644 --- a/lib/MIME/Decoder/NBit.pm +++ b/lib/MIME/Decoder/NBit.pm @@ -1,4 +1,6 @@ package MIME::Decoder::NBit; +use strict; +use warnings; =head1 NAME diff --git a/lib/MIME/Decoder/QuotedPrint.pm b/lib/MIME/Decoder/QuotedPrint.pm index cb20c1f..89a6baa 100644 --- a/lib/MIME/Decoder/QuotedPrint.pm +++ b/lib/MIME/Decoder/QuotedPrint.pm @@ -1,4 +1,6 @@ package MIME::Decoder::QuotedPrint; +use strict; +use warnings; =head1 NAME diff --git a/lib/MIME/Decoder/UU.pm b/lib/MIME/Decoder/UU.pm index c8320dd..7fc995c 100644 --- a/lib/MIME/Decoder/UU.pm +++ b/lib/MIME/Decoder/UU.pm @@ -1,5 +1,6 @@ package MIME::Decoder::UU; - +use strict; +use warnings; =head1 NAME
Download (untitled) / with headers
text/plain 108b
Hi, I have just uploaded MIME-tools-5.503 to CPAN, which I believe resolves this ticket. Regards, David.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.