Skip Menu |
 

This queue is for tickets about the Test-Perl-Critic-Progressive CPAN distribution.

Report information
The Basics
Id: 77275
Status: open
Priority: 0/
Queue: Test-Perl-Critic-Progressive

People
Owner: Nobody in particular
Requestors: hhn [...] jobindex.dk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Adding new policy
Date: Fri, 18 May 2012 14:30:11 +0200
To: <bug-Test-Perl-Critic-Progressive [...] rt.cpan.org>
From: Henrik Hald Nørgaard <hhn [...] jobindex.dk>
Download (untitled) / with headers
text/plain 814b
When I add a new policy to my perlcritic configuration, the number of violations of the new policy is not written to the history file used by Test::Perl::Critic::Progressive. Here is a patch that should fix this : 162a163 Show quoted text
> my $new_policies = 0;
174c175,178 < next if not defined $last_policy_violations; --- Show quoted text
> if (not defined $last_policy_violations) { > $new_policies = 1; > next; > }
212c216 < if ( !$has_run_before || ($ok && $last_total_violations > 0) ) { --- Show quoted text
> if ( !$has_run_before || ($ok && $last_total_violations > 0) ||
$new_policies ) { Kind regards Henrik Hald Nørgaard, Programmør Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf.: +45 38 32 33 55, dir.: +45 38 32 33 81 <http://www.jobindex.dk/> www.jobindex.dk
Download (untitled) / with headers
text/plain 184b
[Sorry for the slow reply -- I've been out of town] Thanks for the patch! I'll put this in the next release. If you happen to have a test case, that would be appreciated too. -Jeff


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.