Skip Menu |
 

This queue is for tickets about the XML-Twig CPAN distribution.

Report information
The Basics
Id: 77112
Status: resolved
Priority: 0/
Queue: XML-Twig

People
Owner: Nobody in particular
Requestors: w.phillip.moore [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.40
Fixed in: (no value)



Subject: Tests fails because HTML::TreeBuilder is not found
While building the latest XML-Twig 3.40, I've found that the test suites will fail if HTML::TreeBuilder is not installed. The workaround is obvious, but if the tests *require* HTML::TreeBuilder then it should really my listed in the META.json file as a required build prereq. In addition, there are a lot of tests which are skipped because a number of other CPAN prereqs are not installed. It would be nice if these were listed as recommends, so that build systems can at least try to make them available (my own system attempts to satisfy recommends as well as requires, for example). Here's the two failures that demonstrate the requirement for HTML::TreeBuilder: 2012-05-10 15:26:43] cannot parse HTML: missing HTML::TreeBuilder v >= 3.13 [2012-05-10 15:26:43] at t/test_3_38.t line 114 [2012-05-10 15:26:43] t/test_3_38.t ....................... [2012-05-10 15:26:43] Dubious, test returned 2 (wstat 512, 0x200) [2012-05-10 15:26:43] Failed 4/21 subtests [2012-05-10 15:26:43] cannot parse HTML: missing HTML::TreeBuilder v >= 3.13 [2012-05-10 15:26:43] at t/test_3_39.t line 59 [2012-05-10 15:26:43] t/test_3_39.t ....................... [2012-05-10 15:26:43] Dubious, test returned 2 (wstat 512, 0x200) [2012-05-10 15:26:43] Failed 4/12 subtests ... ... [2012-05-10 15:26:43] Test Summary Report [2012-05-10 15:26:43] ------------------- [2012-05-10 15:26:43] t/test_3_38.t (Wstat: 512 Tests: 17 Failed: 0) [2012-05-10 15:26:43] Non-zero exit status: 2 [2012-05-10 15:26:43] Parse errors: Bad plan. You planned 21 tests but ran 17. [2012-05-10 15:26:43] t/test_3_39.t (Wstat: 512 Tests: 8 Failed: 0) [2012-05-10 15:26:43] Non-zero exit status: 2 [2012-05-10 15:26:43] Parse errors: Bad plan. You planned 12 tests but ran 8. [2012-05-10 15:26:43] Files=99, Tests=2546, 77 wallclock secs ( 1.85 usr 0.82 sys + 27.23 cusr 17.61 csys = 47.51 CPU\ ) [2012-05-10 15:26:43] Result: FAIL [2012-05-10 15:26:43] Failed 2/99 test programs. 0/2546 subtests failed. [2012-05-10 15:26:43] make: *** [test_dynamic] Error 255
Subject: Re: [rt.cpan.org #77112] Tests fails because HTML::TreeBuilder is not found
Date: Thu, 10 May 2012 18:19:06 +0200
To: bug-XML-Twig [...] rt.cpan.org
From: mirod <xmltwig [...] gmail.com>
Download (untitled) / with headers
text/plain 1.5k
On 05/10/2012 05:44 PM, Phillip Moore via RT wrote: Show quoted text
> Thu May 10 11:44:56 2012: Request 77112 was acted upon. > Transaction: Ticket created by WPMOORE > Queue: XML-Twig > Subject: Tests fails because HTML::TreeBuilder is not found > Broken in: 3.40 > Severity: (no value) > Owner: Nobody > Requestors: w.phillip.moore@gmail.com > Status: new > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=77112>
Hi, Thanks for the report. That's what I get for improving the tests ;--( Show quoted text
> While building the latest XML-Twig 3.40, I've found that the test suites will fail if > HTML::TreeBuilder is not installed. The workaround is obvious, but if the tests *require* > HTML::TreeBuilder then it should really my listed in the META.json file as a required build > prereq.
I have updated the added tests, skipping them ig HTML::TreeBuilder is not available. Could you test the development version at http://xmltwig.org/xmltwig/XML-Twig-3.41.tar.gz or should I set up an environment withou HTML::TreeBuilder myself? Show quoted text
> In addition, there are a lot of tests which are skipped because a number of other CPAN prereqs > are not installed. It would be nice if these were listed as recommends, so that build systems > can at least try to make them available (my own system attempts to satisfy recommends as well > as requires, for example).
I must say I haven't followed closely the development of CPAN::Meta and friends. Do you happen to know how to include a list of recommended modules in Makefile.PL ? Thanks -- mirod
fixed in 3.42 __ mirod


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.