Skip Menu |
 

This queue is for tickets about the Config-IniFiles CPAN distribution.

Report information
The Basics
Id: 77039
Status: resolved
Priority: 0/
Queue: Config-IniFiles

People
Owner: Nobody in particular
Requestors: gregoa [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Changed behaviour on failure in temporary file creation
Date: Mon, 7 May 2012 16:48:56 +0200
To: bug-Config-IniFiles [...] rt.cpan.org
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 881b
Hi, thanks for fixing the temporary filename issue in 2.71! When trying to backport the fix to 2.52 (the version in Debian stable), Adam D. Barratt noted [0] tthat he behaviour has changed: The insecure version carp()ed and returned undef if opening the temporary file failed; tempfile() TTBMOK just croak()s. This might be an unpleasant change for callers that rely on a return value of undef if anything in the function fails. Not sure what's the best way of handling this, so I thought I'd bring it up with you guys :) Cheers, gregor [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671255#44 -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Cat Stevens: Trouble
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 937b
Hi Gregor, thanks for bringing this to our attention. On Mon May 07 10:49:11 2012, gregoa@debian.org wrote: Show quoted text
> Hi, > > thanks for fixing the temporary filename issue in 2.71! >
You're welcome. Show quoted text
> When trying to backport the fix to 2.52 (the version in Debian > stable), Adam D. Barratt noted [0] tthat he behaviour has changed: > The insecure version carp()ed and returned undef if opening the > temporary file failed; tempfile() TTBMOK just croak()s. > > This might be an unpleasant change for callers that rely on a return > value of undef if anything in the function fails. > > Not sure what's the best way of handling this, so I thought I'd bring > it up with you guys :)
One option would be to trap the exception (in as small scope as possible) and return undef (and carp()) if "$@" is true. I'll look into it. Show quoted text
Thanks for the link. Regards, -- Shlomi Fish
Subject: Re: [rt.cpan.org #77039] Changed behaviour on failure in temporary file creation
Date: Tue, 8 May 2012 17:30:03 +0200
To: Shlomi Fish via RT <bug-Config-IniFiles [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 795b
On Tue, 08 May 2012 03:48:48 -0400, Shlomi Fish via RT wrote: Show quoted text
> thanks for bringing this to our attention.
Thanks to you for your quick reply and for considering this request. Show quoted text
> > Not sure what's the best way of handling this, so I thought I'd bring > > it up with you guys :)
> One option would be to trap the exception (in as small scope as > possible) and return undef (and carp()) if "$@" is true. I'll look into it.
Yup, something like that might be a good idea. Thanks in advance! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Ludwig Hirsch: Das kleine Tier
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 227b
Thanks for the report. This was fixed in Config-IniFiles-2.73 which was uploaded to CPAN now. One can find the patch in the BitBucket.org repository: https://bitbucket.org/shlomif/perl-config-inifiles Regards, -- Shlomi Fish


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.