Skip Menu |
 

This queue is for tickets about the MooseX-Daemonize CPAN distribution.

Report information
The Basics
Id: 76523
Status: resolved
Priority: 0/
Queue: MooseX-Daemonize

People
Owner: ether [...] cpan.org
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.13
Fixed in: 0.16



Subject: [PATCH] Cannot rely on undocumented Test::Builder methods
Download (untitled) / with headers
text/plain 335b
Test::MooseX::Daemonize calls undocumented Test::Builder methods which are being removed in coming versions. This patch replaces them with calls to public methods. If you really need to print directly, you can get the relevant filehandles from $Test->output and $Test->failure_output. Or you can use something like Test::SharedFork.
Subject: tb15.patch
Download tb15.patch
text/x-diff 946b
diff --git a/lib/Test/MooseX/Daemonize.pm b/lib/Test/MooseX/Daemonize.pm index 62eab62..faa3a79 100644 --- a/lib/Test/MooseX/Daemonize.pm +++ b/lib/Test/MooseX/Daemonize.pm @@ -52,15 +52,16 @@ sub check_test_output { # We don't just call ok(!$not), because that generates diagnostics of # its own for failures. We only want the diagnostics from the child. - my $num = $Test->current_test; - $Test->current_test( ++$num ); - $Test->_print("$status $num - $text\n"); + my $orig_no_diag = $Test->no_diag; + $Test->no_diag(1); + $Test->ok(!$not, $text); + $Test->no_diag($orig_no_diag); } elsif ( $line =~ s/\A#\s?// ) { $Test->diag($line); } else { - $Test->_print_diag("$label: $line (unrecognised)\n"); + $Test->diag("$label: $line (unrecognised)\n"); } } }
Ping?  This is blocking Test::Builder 1.5.
thanks, applied, will be releasing 0.16 shortly.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.