Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 76189
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: shay [...] cpan.org
Cc: perl5-porters [...] perl.org
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



CC: perl5-porters [...] perl.org
Subject: Test script missing from CGI.pm CPAN distribution?
Download (untitled) / with headers
text/plain 778b
I have noticed that a change was applied to perl (maint-5.12) in Jan 2011 which modified CGI.pm itself and added two new test scripts: headers.t and multipart_init.t: http://perl5.git.perl.org/perl.git/commit/b7fa2aca51 The first two changes do seem to have found their way back to the CGI.pm CPAN distro, but the latter change -- the addition of multipart_init.t -- appears to have been missed. I've checked through every CPAN release from 3.48 through 3.59 and don't see it anywhere, despite the Changes file for 3.52 claiming to have fixed a logic error in it! The current bleadperl version is attached. Could you please consider including it (or a later version if you have one, perhaps including whatever fixes 3.52's Changes file was referring to?) in future releases.
Subject: multipart_init.t
Download multipart_init.t
text/x-perl 722b
use Test::More 'no_plan'; use CGI; my $q = CGI->new; my $sv = $q->multipart_init; like( $sv, qr|Content-Type: multipart/x-mixed-replace;boundary="------- =|, 'multipart_init(), basic'); like( $sv, qr/$CGI::CRLF$/, 'multipart_init(), ends in CRLF' ); $sv = $q->multipart_init( 'this_is_the_boundary' ); like( $sv, qr/boundary="this_is_the_boundary"/, 'multipart_init("simple_boundary")' ); $sv = $q->multipart_init( -boundary => 'this_is_another_boundary' ); like($sv, qr/boundary="this_is_another_boundary"/, "multipart_init( -boundary => 'this_is_another_boundary')"); $sv = $q->multipart_init; my $sv2 = $q->multipart_init; isnt($sv,$sv2,"due to random boundaries, multiple calls produce different results");
Subject: Re: [rt.cpan.org #76189] Test script missing from CGI.pm CPAN distribution?
Date: Mon, 02 Apr 2012 10:25:56 -0400
To: bug-CGI.pm [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Download (untitled) / with headers
text/plain 885b
Show quoted text
> I have noticed that a change was applied to perl (maint-5.12) in Jan > 2011 which modified CGI.pm itself and added two new test scripts: > headers.t and multipart_init.t: > > http://perl5.git.perl.org/perl.git/commit/b7fa2aca51 > > The first two changes do seem to have found their way back to the CGI.pm > CPAN distro, but the latter change -- the addition of multipart_init.t > -- appears to have been missed. > > I've checked through every CPAN release from 3.48 through 3.59 and don't > see it anywhere, despite the Changes file for 3.52 claiming to have > fixed a logic error in it! > > The current bleadperl version is attached. Could you please consider > including it (or a later version if you have one, perhaps including > whatever fixes 3.52's Changes file was referring to?) in future releases.
Thanks for the report. I'll see about making this consistent. Mark
This is being released today. Thanks.
CC: <perl5-porters [...] perl.org>
Subject: RE: [rt.cpan.org #76189] Test script missing from CGI.pm CPAN distribution?
Date: Thu, 16 Aug 2012 09:26:50 +0100
To: <bug-CGI.pm [...] rt.cpan.org>, <shay [...] cpan.org>
From: "Steve Hay" <Steve.Hay [...] verosoftware.com>
Download (untitled) / with headers
text/plain 194b
MARKSTOS via RT wrote on 2012-08-16: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=76189 > > > This is being released today. Thanks.
Thanks, merged into blead in commit a506842e80.
Download (untitled) / with headers
text/plain 240b
This issue has been copied to: https://github.com/leejo/CGI.pm/issues/97 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.
Closing as already resolved as per previous comments


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.