Skip Menu |
 

This queue is for tickets about the Chart CPAN distribution.

Report information
The Basics
Id: 75887
Status: open
Priority: 0/
Queue: Chart

People
Owner: Nobody in particular
Requestors: bdiss [...] flr.follett.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: scalar_png broken with release 2.4.4
Date: Mon, 19 Mar 2012 14:29:02 -0500
To: <bug-Chart [...] rt.cpan.org>
From: "Diss, Bob" <bdiss [...] flr.follett.com>
Download (untitled) / with headers
text/plain 408b
Hello there. Prior to release 2.4.4, the scalar_png method returned the PNG image data as a scalar. This was changed at 2.4.4 to return the constant ³1². This change breaks existing code which expect to receive the image data as the return value of this method. Note that the scalar_jpeg method was not changed -- it still returns the JPEG image data as a scalar. Thanks for investigating this issue.
From: fschlich [...] zedat.fu-berlin.de
Download (untitled) / with headers
text/plain 994b
Hi, I was just about to report the very same issue :-) Here's a patch that we're going to add in the Debian package: --- a/Chart/Base.pm +++ b/Chart/Base.pm @@ -481,7 +481,7 @@ # this method invokes all my private methods to actually # draw the chart and plot the data # @param[in] $dataref Reference to the data to be plotted -# @return Status of the plot +# @return png image as a scalar value sub scalar_png { my $self = shift; @@ -502,8 +502,7 @@ # returns the png image as a scalar value, so that # the programmer/user can do whatever the she/he wants to with it - $self->{'gd_obj'}->png(); - return 1; + return $self->{'gd_obj'}->png(); } ## @method int jpeg($file,$dataref) scalar_png() and scalar_jpeg() aren't documented very well (they are in doxygen, but not mentioned in pod), they lack a test etc. If you're willing to take a more comprehensive patch, I can work on one. BTW this issue breaks Jifty::Plugin::Chart, see RT#75591 Florian
Subject: Re: [rt.cpan.org #75887] scalar_png broken with release 2.4.4
Date: Tue, 20 Mar 2012 10:02:45 +0100
To: bug-Chart [...] rt.cpan.org
From: Reiner Dassing <dassing [...] fs.wettzell.de>
Download (untitled) / with headers
text/plain 1.6k
Hi, thanks for your patch. I will release version 2.4.5 within the next days. Show quoted text
> scalar_png() and scalar_jpeg() aren't documented very well (they are in > doxygen, but not mentioned in pod), they lack a test etc. If you're > willing to take a more comprehensive patch, I can work on one.
Any help for improving the module is very welcome. (As I am alone and doing this work during some off hours any help is appreciated.) Thanks Reiner Am 19.03.2012 22:37, schrieb Florian via RT: Show quoted text
> Queue: Chart > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=75887> > > Hi, > > I was just about to report the very same issue :-) > Here's a patch that we're going to add in the Debian package: > > --- a/Chart/Base.pm > +++ b/Chart/Base.pm > @@ -481,7 +481,7 @@ > # this method invokes all my private methods to actually > # draw the chart and plot the data > # @param[in] $dataref Reference to the data to be plotted > -# @return Status of the plot > +# @return png image as a scalar value > sub scalar_png > { > my $self = shift; > @@ -502,8 +502,7 @@ > > # returns the png image as a scalar value, so that > # the programmer/user can do whatever the she/he wants to with it > - $self->{'gd_obj'}->png(); > - return 1; > + return $self->{'gd_obj'}->png(); > } > > ## @method int jpeg($file,$dataref) > > > scalar_png() and scalar_jpeg() aren't documented very well (they are in > doxygen, but not mentioned in pod), they lack a test etc. If you're > willing to take a more comprehensive patch, I can work on one. > > BTW this issue breaks Jifty::Plugin::Chart, see RT#75591 > > Florian > >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.