Skip Menu |
 

This queue is for tickets about the Symbol-Util CPAN distribution.

Report information
The Basics
Id: 75763
Status: resolved
Priority: 0/
Queue: Symbol-Util

People
Owner: piotr.roszatycki [...] gmail.com
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.0202
Fixed in: 0.0203



Subject: Multiple deprecation messages - defined %hash
Download (untitled) / with headers
text/plain 234b
The current standing from p5p is that the check defined %hash has no meaning and doesn't actually do what you want. It's deprecated in perl 5.12. you should instead just do %hash I'm attaching a patch to fix the test suite for this.
Subject: Symbol-Util-0.0202.patch
commit b0bcf347e84d51edf9cc6e3c18e1b922735306b1 Author: Todd Rinaldo <toddr@cpan.org> Date: Tue Mar 13 21:01:46 2012 -0500 Remove defined hash deprecations from test suite diff --git a/t/40delete_glob.t b/t/40delete_glob.t index 407872a..40dd4dd 100644 --- a/t/40delete_glob.t +++ b/t/40delete_glob.t @@ -40,21 +40,21 @@ ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [2]' ok( defined delete_glob("Symbol::Util::Test40::FOO", "ARRAY", "HASH"), 'delete_glob("Symbol::Util::Test40::FOO", "ARRAY", "HASH")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [3]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [3]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [3]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [3]' ); is( eval { &Symbol::Util::Test40::FOO }, 'code', '&Symbol::Util::Test40::FOO is ok [3]' ); ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [3]' ); ok( defined delete_glob("Symbol::Util::Test40::FOO", "CODE"), 'delete_glob("Symbol::Util::Test40::FOO", "CODE")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [4]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [4]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [4]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [4]' ); ok( ! eval { &Symbol::Util::Test40::FOO }, '&Symbol::Util::Test40::FOO is ok [4]' ); ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [4]' ); ok( defined delete_glob("Symbol::Util::Test40::FOO", "IO"), 'delete_glob("Symbol::Util::Test40::FOO", "IO")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [5]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [5]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [5]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [5]' ); ok( ! eval { &Symbol::Util::Test40::FOO }, '&Symbol::Util::Test40::FOO is ok [5]' ); ok( ! fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [5]' ); @@ -97,7 +97,7 @@ ok( ! fileno Symbol::Util::Test40::BAR, '*Symbol::Util::Test40::BAR{IO} is ok [3 ok( ! defined delete_glob("Symbol::Util::Test40::BAR"), 'delete_glob("Symbol::Util::Test40::BAR") [1]' ); ok( ! defined $Symbol::Util::Test40::BAR, '$Symbol::Util::Test40::BAR is ok [4]' ); ok( ! defined @Symbol::Util::Test40::BAR, '@Symbol::Util::Test40::BAR is ok [4]' ); -ok( ! defined %Symbol::Util::Test40::BAR, '%Symbol::Util::Test40::BAR is ok [4]' ); +ok( ! %Symbol::Util::Test40::BAR, '%Symbol::Util::Test40::BAR is ok [4]' ); ok( ! eval { &Symbol::Util::Test40::BAR }, '&Symbol::Util::Test40::BAR is ok [4]' ); ok( ! fileno Symbol::Util::Test40::BAR, '*Symbol::Util::Test40::BAR{IO} is ok [4]' ); diff --git a/t/80export_package.t b/t/80export_package.t index 8122acf..8d9a7b7 100644 --- a/t/80export_package.t +++ b/t/80export_package.t @@ -211,7 +211,7 @@ unexport_package("Symbol::Util::Test80::Target9", "Symbol::Util::Test80::Source1 pass( 'unexport_package("Symbol::Util::Test80::Target9", "Symbol::Util::Test80::Source1")' ); ok( ! defined @Symbol::Util::Test80::Target9::BAZ, '@Symbol::Util::Test80::Target9::BAZ is ok [2]' ); -ok( ! defined %Symbol::Util::Test80::Target9::BAZ, '%Symbol::Util::Test80::Target9::BAZ is ok [2]' ); +ok( ! %Symbol::Util::Test80::Target9::BAZ, '%Symbol::Util::Test80::Target9::BAZ is ok [2]' ); ok( ! defined *Symbol::Util::Test80::Target9::BAZ{IO}, '*Symbol::Util::Test80::Target9::BAZ{IO} is ok [2]' ); {
changing file extension so it'll display
Subject: Symbol-Util-0.0202.patch.txt
commit b0bcf347e84d51edf9cc6e3c18e1b922735306b1 Author: Todd Rinaldo <toddr@cpan.org> Date: Tue Mar 13 21:01:46 2012 -0500 Remove defined hash deprecations from test suite diff --git a/t/40delete_glob.t b/t/40delete_glob.t index 407872a..40dd4dd 100644 --- a/t/40delete_glob.t +++ b/t/40delete_glob.t @@ -40,21 +40,21 @@ ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [2]' ok( defined delete_glob("Symbol::Util::Test40::FOO", "ARRAY", "HASH"), 'delete_glob("Symbol::Util::Test40::FOO", "ARRAY", "HASH")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [3]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [3]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [3]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [3]' ); is( eval { &Symbol::Util::Test40::FOO }, 'code', '&Symbol::Util::Test40::FOO is ok [3]' ); ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [3]' ); ok( defined delete_glob("Symbol::Util::Test40::FOO", "CODE"), 'delete_glob("Symbol::Util::Test40::FOO", "CODE")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [4]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [4]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [4]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [4]' ); ok( ! eval { &Symbol::Util::Test40::FOO }, '&Symbol::Util::Test40::FOO is ok [4]' ); ok( fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [4]' ); ok( defined delete_glob("Symbol::Util::Test40::FOO", "IO"), 'delete_glob("Symbol::Util::Test40::FOO", "IO")' ); ok( ! defined $Symbol::Util::Test40::FOO, '$Symbol::Util::Test40::FOO is ok [5]' ); ok( ! defined @Symbol::Util::Test40::FOO, '@Symbol::Util::Test40::FOO is ok [5]' ); -ok( ! defined %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [5]' ); +ok( ! %Symbol::Util::Test40::FOO, '%Symbol::Util::Test40::FOO is ok [5]' ); ok( ! eval { &Symbol::Util::Test40::FOO }, '&Symbol::Util::Test40::FOO is ok [5]' ); ok( ! fileno Symbol::Util::Test40::FOO, '*Symbol::Util::Test40::FOO{IO} is ok [5]' ); @@ -97,7 +97,7 @@ ok( ! fileno Symbol::Util::Test40::BAR, '*Symbol::Util::Test40::BAR{IO} is ok [3 ok( ! defined delete_glob("Symbol::Util::Test40::BAR"), 'delete_glob("Symbol::Util::Test40::BAR") [1]' ); ok( ! defined $Symbol::Util::Test40::BAR, '$Symbol::Util::Test40::BAR is ok [4]' ); ok( ! defined @Symbol::Util::Test40::BAR, '@Symbol::Util::Test40::BAR is ok [4]' ); -ok( ! defined %Symbol::Util::Test40::BAR, '%Symbol::Util::Test40::BAR is ok [4]' ); +ok( ! %Symbol::Util::Test40::BAR, '%Symbol::Util::Test40::BAR is ok [4]' ); ok( ! eval { &Symbol::Util::Test40::BAR }, '&Symbol::Util::Test40::BAR is ok [4]' ); ok( ! fileno Symbol::Util::Test40::BAR, '*Symbol::Util::Test40::BAR{IO} is ok [4]' ); diff --git a/t/80export_package.t b/t/80export_package.t index 8122acf..8d9a7b7 100644 --- a/t/80export_package.t +++ b/t/80export_package.t @@ -211,7 +211,7 @@ unexport_package("Symbol::Util::Test80::Target9", "Symbol::Util::Test80::Source1 pass( 'unexport_package("Symbol::Util::Test80::Target9", "Symbol::Util::Test80::Source1")' ); ok( ! defined @Symbol::Util::Test80::Target9::BAZ, '@Symbol::Util::Test80::Target9::BAZ is ok [2]' ); -ok( ! defined %Symbol::Util::Test80::Target9::BAZ, '%Symbol::Util::Test80::Target9::BAZ is ok [2]' ); +ok( ! %Symbol::Util::Test80::Target9::BAZ, '%Symbol::Util::Test80::Target9::BAZ is ok [2]' ); ok( ! defined *Symbol::Util::Test80::Target9::BAZ{IO}, '*Symbol::Util::Test80::Target9::BAZ{IO} is ok [2]' ); {
Download (untitled) / with headers
text/plain 120b
Already patched at https://github.com/dex4er/perl-Symbol-Util The release will be soon. Thank you very much for help.
Released Symbol-Util-0.0203 Thanks for report!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.