Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 75487
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: me [...] eboxr.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.45
Fixed in: (no value)



Subject: get_my_thread_id call method 'tid' if no threads used
Download (untitled) / with headers
text/plain 871b
When bootstrapping Net::SSleay ( with DynaLoader ) if you override the SIG{DIE} signal, using Net::SSLeay will result in an error. We do not check if threads are used before calling this method. It will be nice to check it before, but here is an easy patch that will do it in the function. (internal error) Fri Mar 2 14:14:11 2012 [4605] error: Can't locate object method "tid" via package "threads" (perhaps you forgot to load "threads"?) at /usr/local/lib/perl5/5.8.8/x86_64- linux/DynaLoader.pm line 248. at /usr/local/lib/perl5/5.8.8/x86_64-linux/DynaLoader.pm line 248 eval {...} called at /usr/local/lib/perl5/5.8.8/x86_64-linux/DynaLoader.pm line 248 DynaLoader::bootstrap('Net::SSLeay', 1.45) called at /usr/local/lib/perl5/5.8.8/x86_64- linux/DynaLoader.pm line 119 DynaLoader::bootstrap_inherit('Net::SSLeay', 1.45) called at lib/Net/SSLeay.pm line 630
Subject: 0001-patch.patch
Download 0001-patch.patch
text/x-diff 720b
From 0260895704c9103c534c2880acf6ce537923fe9a Mon Sep 17 00:00:00 2001 From: Nicolas R, <me@eboxr.com> Date: Fri, 2 Mar 2012 14:55:37 -0600 Subject: [PATCH] patch --- SSLeay.xs | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index ad89735..f4cabd2 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -106,8 +106,9 @@ UV get_my_thread_id(void) /* returns threads->tid() value */ { dSP; UV tid; - int count; + int count = 0; +#ifdef USE_ITHREADS ENTER; SAVETMPS; PUSHMARK(SP); @@ -123,6 +124,7 @@ UV get_my_thread_id(void) /* returns threads->tid() value */ PUTBACK; FREETMPS; LEAVE; +#endif return tid; } -- 1.7.7.4
Subject: Re: [rt.cpan.org #75487] get_my_thread_id call method 'tid' if no threads used
Date: Sat, 03 Mar 2012 08:18:45 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Download (untitled) / with headers
text/plain 865b
Hello, thanks for this report and patch. It has now been added to svn commit 30 On Friday, March 02, 2012 03:59:38 PM you wrote: Show quoted text
> When bootstrapping Net::SSleay ( with DynaLoader ) if you override the > SIG{DIE} signal, using Net::SSLeay will result in an error.
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.