Skip Menu |
 

This queue is for tickets about the Dist-Zilla-Plugin-ReadmeFromPod CPAN distribution.

Report information
The Basics
Id: 75273
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-ReadmeFromPod

People
Owner: Nobody in particular
Requestors: rjbs [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: should be FileGatherer, not InstallTool
Download (untitled) / with headers
text/plain 145b
Probably it's an InstallTool for ordering reasons. These won't be relevant if it produces a FromCode file instead of a InMemory file. -- rjbs
Download (untitled) / with headers
text/plain 580b
I applied the patch from RT 75272. but this error is very annoying [DZ] attempt to add README multiple times; added by: @Filter/Readme (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod (Dist::Zilla::Plugin::ReadmeFromPod line 67) aborting; duplicate files would be produced at /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 that we need use [@Filter] remove = Readme [ReadmeFromPod] to fix. but I think the people who use ReadmeFromPod will have "discard Readme" in his mind. how about write some code to do it by default? Thanks
at last I still roll it back to InstallTool because the POD must be after PodWeaver. Thanks
Download (untitled) / with headers
text/plain 446b
On 2012-02-24 23:09:19, FAYLAND wrote: Show quoted text
> at last I still roll it back to InstallTool > > because the POD must be after PodWeaver.
If the file created is a File::FromCode, then the content is not generated until read. That means that it will not be generated until written to disk during the final moments of build. By that point, FileMunging is done. That is exactly why FromCode files exist. Using InstallTool is not necessary. -- rjbs
Download (untitled) / with headers
text/plain 383b
but I want to avoid [DZ] attempt to add README multiple times; added by: @Filter/Readme (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod (Dist::Zilla::Plugin::ReadmeFromPod line 67) aborting; duplicate files would be produced at /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 and I don't want to add remove = Readme is there a way to do it? Thanks.
On 2012-02-24 23:53:48, FAYLAND wrote: Show quoted text
> but I want to avoid > > [DZ] attempt to add README multiple times; added by: @Filter/Readme > (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod > (Dist::Zilla::Plugin::ReadmeFromPod line 67) > aborting; duplicate files would be produced at > /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 > > and I don't want to add > > remove = Readme > > is there a way to do it?
Every other FileGatherer plugin lives by the "just add the file; the user has to keep track of not adding more than one." I think it is not a great idea to silently throw away other README files. It will hide misconfiguration. It also means that your plugin is not acting like most other plugins that do similar jobs. Anyway: No, you can't easily avoid the rule above if you are just a FileGatherer. While you could remove any README file you find when running, it wouldn't be effective if the other README is added after you. (In practice, most users will have [ReadmeFromPod] later than [GatherDir], but not all.) Going to bed now. Good night! -- rjbs
Looks like this dist is still using InstallTool? I has sad panda.
Download (untitled) / with headers
text/plain 261b
On Sat, 25 Feb 2012 04:09:19 GMT, FAYLAND wrote: Show quoted text
> at last I still roll it back to InstallTool > > because the POD must be after PodWeaver. > > Thanks
BTW, isn't ordering supposed to be done by the order we specify the plugins in dist.ini (or PluginBundle)?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.