Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 75264
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: POD coverage fail
Date: Fri, 24 Feb 2012 09:54:41 +0000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 470b
Net-SSLeay-1.43 fails its test suite in two ways. One (missing data file) has been covered in [rt.cpan.org #75261]. The other is the POD coverage test: # Failed test 'Pod coverage on Net::SSLeay' # at t/local/02_pod_coverage.t line 11. # Coverage for Net::SSLeay is 99.7%, with 1 naked subroutine: # SESSION_cmp # Looks like you failed 1 test of 2. t/local/02_pod_coverage.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests -zefram
From: paul [...] city-fan.org
Download (untitled) / with headers
text/plain 742b
On Fri Feb 24 04:54:54 2012, zefram@fysh.org wrote: Show quoted text
> Net-SSLeay-1.43 fails its test suite in two ways. One (missing data > file) has been covered in [rt.cpan.org #75261]. The other is the POD > coverage test: > > # Failed test 'Pod coverage on Net::SSLeay' > # at t/local/02_pod_coverage.t line 11. > # Coverage for Net::SSLeay is 99.7%, with 1 naked subroutine: > # SESSION_cmp > # Looks like you failed 1 test of 2. > t/local/02_pod_coverage.t ...... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/2 subtests > > -zefram
This happens with openssl < 1. Attached patch should fix it. Whilst making this patch I noticed that the word "corresponding" was mis-spelled as "coresponding" throughout the POD by the way.
Subject: Net-SSLeay-1.43-pod.patch
Pod coverage test fails with openssl < 1 due to this function being available and undocumented. --- Net-SSLeay-1.43/lib/Net/SSLeay.pod +++ Net-SSLeay-1.43/lib/Net/SSLeay.pod @@ -1214,6 +1214,18 @@ Check openssl doc L<http://www.openssl.org/docs/ssl/SSL_SESSION_free.html|http://www.openssl.org/docs/ssl/SSL_SESSION_free.html> +=item * SESSION_cmp + +Compare two SSL_SESSION structures. + + my $rv = Net::SSLeay::SESSION_cmp($sesa, $sesb); + # $sesa - value corresponding to openssl's SSL_SESSION structure + # $sesb - value corresponding to openssl's SSL_SESSION structure + # + # returns: 0 if the two structures are the same + +B<NOTE:> Not available in openssl 1.0 or later + =item * SESSION_get_app_data Can be used to get application defined value/data.
From: paul [...] city-fan.org
Download (untitled) / with headers
text/plain 168b
And another thing: the test suite's use of BAIL_OUT means it now requires at least version 0.60_01 of Test::More, which should be reflected in the META.yml/Makefile.PL.
Show quoted text
> Whilst making this patch I noticed that the word "corresponding" was
> mis-spelled as "coresponding" throughout the POD by the way.

this is my fault - please apply enclosed patch

--
kmx

Subject: corresponding_typo_r307.diff

Message body is not shown because it is too large.

Subject: Re: [rt.cpan.org #75264] POD coverage fail
Date: Tue, 13 Mar 2012 08:02:31 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Download (untitled) / with headers
text/plain 985b
Hi, Patched in svn Thanks. Cheers. On Monday, March 12, 2012 03:32:20 PM you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75264 > >
> > Whilst making this patch I noticed that the word "corresponding" was > > mis-spelled as "coresponding" throughout the POD by the way.
> > this is my fault - please apply enclosed patch > > -- > kmx
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.