Skip Menu |
 

This queue is for tickets about the Data-Alias CPAN distribution.

Report information
The Basics
Id: 75156
Status: resolved
Priority: 0/
Queue: Data-Alias

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.16
Fixed in: (no value)

Attachments


Subject: [PATCH] Fix build with dtrace and Perl < 5.13.8
Download (untitled) / with headers
text/plain 473b
The build of Data::Alias fails on dtrace/systemtap enabled builds on perl < 5.13.8 because prior to that version, the RETURN_PROBE macro had three parameters rather than the four specified in Alias.xs (the commit adding the extra parameter was http://perl5.git.perl.org/perl.git/commitdiff/3e2413e5f999573e5bcccfb506d8a449a3ab690b). A sample failure can be found here: http://www.cpantesters.org/cpan/report/8084d84a-11ac-11e1-8250-a0fc2756887d Attached patch fixes this.
Subject: Data-Alias-1.16-dtrace.patch
Prior to Perl 5.13.8, ENTRY_PROBE and RETURN_PROBE had 3 arguments each, not 4. http://perl5.git.perl.org/perl.git/commitdiff/3e2413e5f999573e5bcccfb506d8a449a3ab690b --- Data-Alias-1.16/Alias.xs +++ Data-Alias-1.16/Alias.xs @@ -28,9 +28,14 @@ #if defined(USE_DTRACE) && defined(PERL_CORE) #undef ENTRY_PROBE #undef RETURN_PROBE +#if (PERL_COMBI_VERSION < 5013008) +#define ENTRY_PROBE(func, file, line) +#define RETURN_PROBE(func, file, line) +#else #define ENTRY_PROBE(func, file, line, stash) #define RETURN_PROBE(func, file, line, stash) #endif +#endif #if defined(PERL_CORE) && defined(MULTIPLICITY) && \ (PERL_COMBI_VERSION < 5013006)
Subject: Re: [rt.cpan.org #75156] [PATCH] Fix build with dtrace and Perl < 5.13.8
Date: Wed, 22 Feb 2012 19:41:53 +0000
To: "paul [...] city-fan.org via RT" <bug-Data-Alias [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
Thanks. Will be in the next release. -zefram
Download (untitled) / with headers
text/plain 449b
On Wed Feb 22 14:42:04 2012, zefram@fysh.org wrote: Show quoted text
> Thanks. Will be in the next release. > > -zefram
I can reaffirm that the patch posted for this bug fixes the issue for me, and doesn't appear to cause any issues on any other systems. I would love to see a release with this patch, as the current version on CPAN prevents me from installing Method::Signatures on my mac without having to first manually install Data::Alias with this patch.
From: PJF [...] cpan.org
Download (untitled) / with headers
text/plain 231b
And in case anyone needs total instant gratification *right now*, I've just built a copy of Data::Alias 1.16 with the patch applied in tarball form: cpanm https://dl.dropbox.com/u/9702672/cpan/Data-Alias-1.16-dtrace-patched.tar.gz
From: PJF [...] cpan.org
Download (untitled) / with headers
text/plain 185b
I've now had my third user hit this bug. :( I'm willing to sing and tweet praise and compose poetry if we can get an official release out that contains the patch in question. :) Paul
Fixed in Data-Alias-1.17, now on CPAN.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.