Skip Menu |
 

This queue is for tickets about the DBIx-SearchBuilder CPAN distribution.

Report information
The Basics
Id: 75066
Status: resolved
Priority: 0/
Queue: DBIx-SearchBuilder

People
Owner: Nobody in particular
Requestors: Martin.King [...] arm.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Incorrect use of UNIVERSAL::isa() at line 1327 of DBIx::SearchBuilder::Record ????
Date: Thu, 16 Feb 2012 17:17:37 +0000
To: "bug-DBIx-SearchBuilder [...] rt.cpan.org" <bug-DBIx-SearchBuilder [...] rt.cpan.org>
From: Martin King <Martin.King [...] arm.com>
Download (untitled) / with headers
text/plain 977b
Version 1.59, but it looks like it's in 1.61, too. I caught this using SQLite with foreign key constraints and deleting a constrained row: Use of uninitialized value in subroutine entry at /.../lib/site_perl/5.12/DBIx/SearchBuilder/Record.pm line 1327. at /.../lib/site_perl/5.12/DBIx/SearchBuilder/Record.pm line 1327 DBIx::SearchBuilder::Record::__Delete('ARM::Field=HASH(0x4f4c2d0)') called at /.../lib/site_perl/5.12/DBIx/SearchBuilder/Record.pm line 1305 I think the line should read: if (UNIVERSAL::isa($return, 'Class::ReturnValue')) { and not: if (UNIVERSAL::isa('Class::ReturnValue', $return)) { Regards, Martin King -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Subject: Re: [rt.cpan.org #75066] Incorrect use of UNIVERSAL::isa() at line 1327 of DBIx::SearchBuilder::Record ????
Date: Fri, 17 Feb 2012 12:34:12 -0500
To: bug-DBIx-SearchBuilder [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
Download (untitled) / with headers
text/plain 311b
On 02/16/2012 12:17 PM, Martin King via RT wrote: Show quoted text
> I think the line should read: > > if (UNIVERSAL::isa($return, 'Class::ReturnValue')) { > > and not: > > if (UNIVERSAL::isa('Class::ReturnValue', $return)) {
Thanks, applied as <https://github.com/bestpractical/dbix-searchbuilder/commit/2a95607a>. Thomas


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.